diff options
author | Kaleb S KEITHLEY <kkeithle@redhat.com> | 2015-12-18 07:44:45 -0500 |
---|---|---|
committer | Niels de Vos <ndevos@redhat.com> | 2015-12-22 09:15:01 -0800 |
commit | e62c0fe19b113d42db5e0f80fa7cbb82f2f88190 (patch) | |
tree | 584016bcf8df4069c2795d87967c9c3a7fe230ab /xlators/storage | |
parent | 76f1680a2de05420934e131f934f3895fbe50db8 (diff) |
build: export minimum symbols from xlators for correct resolution
Revisiting http://review.gluster.org/#/c/11814/, which unintentionally
introduced warnings from libtool about the xlator .so names.
According to [1], the -module option must appear in the Makefile.am
file(s); if -module is defined in a macro, e.g. in configure(.ac),
then libtool will not recognize that this is a module and will emit a
warning.
[1]
http://www.gnu.org/software/automake/manual/automake.html#Libtool-Modules
Change-Id: Ifa5f9327d18d139597791c305aa10cc4410fb078
BUG: 1248669
Signed-off-by: Kaleb S KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/13003
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: soumya k <skoduri@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Diffstat (limited to 'xlators/storage')
-rw-r--r-- | xlators/storage/bd/src/Makefile.am | 2 | ||||
-rw-r--r-- | xlators/storage/posix/src/Makefile.am | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/xlators/storage/bd/src/Makefile.am b/xlators/storage/bd/src/Makefile.am index f0fbc24086a..aad293e0c79 100644 --- a/xlators/storage/bd/src/Makefile.am +++ b/xlators/storage/bd/src/Makefile.am @@ -2,7 +2,7 @@ if ENABLE_BD_XLATOR xlator_LTLIBRARIES = bd.la xlatordir = $(libdir)/glusterfs/$(PACKAGE_VERSION)/xlator/storage -bd_la_LDFLAGS = $(GF_XLATOR_DEFAULT_LDFLAGS) +bd_la_LDFLAGS = -module $(GF_XLATOR_DEFAULT_LDFLAGS) LIBBD = -llvm2app -lrt bd_la_SOURCES = bd.c bd-helper.c bd-aio.c bd_la_LIBADD = $(top_builddir)/libglusterfs/src/libglusterfs.la $(LIBBD) $(LIBAIO) diff --git a/xlators/storage/posix/src/Makefile.am b/xlators/storage/posix/src/Makefile.am index 6de572992db..4e3fd3dd09e 100644 --- a/xlators/storage/posix/src/Makefile.am +++ b/xlators/storage/posix/src/Makefile.am @@ -2,7 +2,7 @@ xlator_LTLIBRARIES = posix.la xlatordir = $(libdir)/glusterfs/$(PACKAGE_VERSION)/xlator/storage -posix_la_LDFLAGS = $(GF_XLATOR_DEFAULT_LDFLAGS) +posix_la_LDFLAGS = -module $(GF_XLATOR_DEFAULT_LDFLAGS) posix_la_SOURCES = posix.c posix-helpers.c posix-handle.c posix-aio.c posix_la_LIBADD = $(top_builddir)/libglusterfs/src/libglusterfs.la $(LIBAIO) \ |