diff options
| author | Michael Scherer <misc@redhat.com> | 2017-02-23 22:57:42 +0100 |
|---|---|---|
| committer | Jeff Darcy <jeff@pl.atyp.us> | 2017-05-04 14:59:29 +0000 |
| commit | 7c98143c7928f4ec936c90f0125b2a2aaf8f5174 (patch) | |
| tree | 757a5f799b9ec3caf555b5b1df7db72260cd071e /xlators | |
| parent | 5c68937ef943a5ed8179cb19fef833f2be790588 (diff) | |
mgmt: Fix null pointer deref
since "this" can be NULL, we should skip this
validation, there is another call to GF_VALIDATE_OR_GOTO
in the following lines. Found by cppcheck.
Change-Id: I329f50b986a9eaf3315e09f851080ab41bea57c0
BUG: 789278
Signed-off-by: Michael Scherer <misc@redhat.com>
Reviewed-on: https://review.gluster.org/16742
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
Tested-by: Jeff Darcy <jeff@pl.atyp.us>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Diffstat (limited to 'xlators')
| -rw-r--r-- | xlators/mgmt/glusterd/src/glusterd-tierd-svc.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/xlators/mgmt/glusterd/src/glusterd-tierd-svc.c b/xlators/mgmt/glusterd/src/glusterd-tierd-svc.c index 638d4941521..f58c6641f96 100644 --- a/xlators/mgmt/glusterd/src/glusterd-tierd-svc.c +++ b/xlators/mgmt/glusterd/src/glusterd-tierd-svc.c @@ -434,7 +434,6 @@ glusterd_tierdsvc_reconfigure (void *data) glusterd_volinfo_t *volinfo = NULL; volinfo = data; - GF_VALIDATE_OR_GOTO (this->name, data, out); /* reconfigure function is not available for other volume based * service. but it has been implemented for tier because there can be |