diff options
| author | yanping.gao <yanping.gao@xtaotech.com> | 2016-08-24 06:47:49 +0000 |
|---|---|---|
| committer | Pranith Kumar Karampuri <pkarampu@redhat.com> | 2016-08-26 08:02:49 -0700 |
| commit | 50fa85c071553b41f33a8167b31c8a9b54cfe3e3 (patch) | |
| tree | a62c1db374ff7cf93d3cfd352589bfc0e2deb868 /xlators | |
| parent | 862ad9132360595c64b098e661288aef7907d5ba (diff) | |
features/locks: fix fdctx leak in locks xlators
Problem:
Locks xlators is leaking fdctx in pl_release when
inode_ctx_get return non-zero
Fix:
This patch fixes fdctx leak in pl_release path
> Reviewed-on: http://review.gluster.org/15302
> Smoke: Gluster Build System <jenkins@build.gluster.org>
> CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
> NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
> Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
> Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Change-Id: Icd5c5c681b7d890e7971b3b06d4258a51d45097d
BUG: 1370390
Signed-off-by: Yanping.gao <yanping.gao@xtaotech.com>
Signed-off-by: Oleksandr Natalenko <oleksandr@natalenko.name>
Reviewed-on: http://review.gluster.org/15323
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Diffstat (limited to 'xlators')
| -rw-r--r-- | xlators/features/locks/src/posix.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/xlators/features/locks/src/posix.c b/xlators/features/locks/src/posix.c index b625178c0e1..3415d59324c 100644 --- a/xlators/features/locks/src/posix.c +++ b/xlators/features/locks/src/posix.c @@ -2588,7 +2588,7 @@ pl_release (xlator_t *this, fd_t *fd) ret = inode_ctx_get (fd->inode, this, &tmp_pl_inode); if (ret != 0) - goto out; + goto clean; pl_inode = (pl_inode_t *)(long)tmp_pl_inode; @@ -2600,6 +2600,7 @@ pl_release (xlator_t *this, fd_t *fd) delete_locks_of_fd (this, pl_inode, fd); pl_update_refkeeper (this, fd->inode); +clean: ret = fd_ctx_del (fd, this, &tmp); if (ret) { gf_log (this->name, GF_LOG_DEBUG, |