diff options
| author | Ravishankar N <ravishankar@redhat.com> | 2018-01-16 10:16:41 +0530 |
|---|---|---|
| committer | Shyamsundar Ranganathan <srangana@redhat.com> | 2018-01-18 18:21:37 +0000 |
| commit | f731824440c218999437412c569bacacf213d191 (patch) | |
| tree | 23ff52885ccb8671457567a9a3c0271391fff28b /xlators | |
| parent | 9601ff350dd309714ec3fa746a86e13ac1165591 (diff) | |
posix: delete stale gfid handles in nameless lookup
..in order for self-heal of symlinks to work properly (see BZ for
details).
Backport of https://review.gluster.org/#/c/19070/
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Change-Id: I9a011d00b07a690446f7fd3589e96f840e8b7501
BUG: 1534848
Diffstat (limited to 'xlators')
| -rw-r--r-- | xlators/storage/posix/src/posix.c | 17 |
1 files changed, 16 insertions, 1 deletions
diff --git a/xlators/storage/posix/src/posix.c b/xlators/storage/posix/src/posix.c index 3fd58b62454..e5ea5388fe5 100644 --- a/xlators/storage/posix/src/posix.c +++ b/xlators/storage/posix/src/posix.c @@ -156,7 +156,10 @@ posix_lookup (call_frame_t *frame, xlator_t *this, dict_t * xattr = NULL; char * real_path = NULL; char * par_path = NULL; + char *gfid_path = NULL; + uuid_t gfid = {0}; struct iatt postparent = {0,}; + struct stat statbuf = {0}; int32_t gfidless = 0; char *pgfid_xattr_key = NULL; int32_t nlink_samepgfid = 0; @@ -205,7 +208,19 @@ posix_lookup (call_frame_t *frame, xlator_t *this, "lstat on %s failed", real_path ? real_path : "null"); } - + if (loc_is_nameless(loc)) { + if (!op_errno) + op_errno = ESTALE; + loc_gfid (loc, gfid); + MAKE_HANDLE_ABSPATH (gfid_path, this, gfid); + op_ret = sys_lstat(gfid_path, &statbuf); + if (op_ret == 0 && statbuf.st_nlink == 1) { + gf_msg (this->name, GF_LOG_WARNING, ESTALE, + P_MSG_HANDLE_DELETE, "Found stale gfid " + "handle %s, removing it.", gfid_path); + posix_handle_unset (this, gfid, NULL); + } + } entry_ret = -1; goto parent; } |