diff options
| author | Kaushik BV <kaushikbv@gluster.com> | 2011-07-12 05:33:37 +0000 |
|---|---|---|
| committer | Anand Avati <avati@gluster.com> | 2011-07-12 09:03:44 -0700 |
| commit | 2f457d1a6441903327b0da5e01f9cad186b13ef5 (patch) | |
| tree | 295b1ab74ea585db1d4fdca9cb293935c7d43662 /xlators | |
| parent | aa9f9c3113009f136642e9bdedfcef6d04d85b44 (diff) | |
quick-read: changes in volume_options to assist volume set help/help-xml
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2041 (volume set help option)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2041
Diffstat (limited to 'xlators')
| -rw-r--r-- | xlators/performance/quick-read/src/quick-read.c | 21 |
1 files changed, 20 insertions, 1 deletions
diff --git a/xlators/performance/quick-read/src/quick-read.c b/xlators/performance/quick-read/src/quick-read.c index d19fa2cf68d..fb7e67abcd6 100644 --- a/xlators/performance/quick-read/src/quick-read.c +++ b/xlators/performance/quick-read/src/quick-read.c @@ -22,6 +22,8 @@ #define QR_DEFAULT_CACHE_SIZE 134217728 +struct volume_options options[]; + void qr_local_free (qr_local_t *local) { @@ -3497,6 +3499,7 @@ init (xlator_t *this) int32_t ret = -1, i = 0; qr_private_t *priv = NULL; qr_conf_t *conf = NULL; + char *def_val = NULL; if (!this->children || this->children->next) { gf_log (this->name, GF_LOG_ERROR, @@ -3546,7 +3549,21 @@ init (xlator_t *this) } } - conf->cache_size = QR_DEFAULT_CACHE_SIZE; + if (xlator_get_volopt_info (&this->volume_options, "cache-size", + &def_val, NULL)) { + gf_log (this->name, GF_LOG_ERROR, "Default value of " + "cache-size not found"); + ret = -1; + goto out; + } else { + if (gf_string2bytesize (def_val, &conf->cache_size)) { + gf_log (this->name, GF_LOG_ERROR, "Default value of " + "cache-size corrupt"); + ret = -1; + goto out; + } + } + ret = dict_get_str (this->options, "cache-size", &str); if (ret == 0) { ret = gf_string2bytesize (str, &conf->cache_size); @@ -3640,6 +3657,8 @@ struct volume_options options[] = { .type = GF_OPTION_TYPE_SIZET, .min = 0, .max = 6 * GF_UNIT_GB, + .default_value = "128MB", + .description = "Size of the read cache." }, { .key = {"cache-timeout"}, .type = GF_OPTION_TYPE_INT, |