diff options
author | Ashish Pandey <aspandey@redhat.com> | 2016-06-06 10:17:54 +0530 |
---|---|---|
committer | Jeff Darcy <jdarcy@redhat.com> | 2016-06-06 14:34:06 -0700 |
commit | eb7ba8984c5e66b57d592f9da606fbdd1133df3b (patch) | |
tree | 0dc695b2ad416015eb89dc7bba19fca7a0bee23a /xlators | |
parent | 9b4169255224b725e7d3455c63e2f9db33b0f3bf (diff) |
cluster/ec: Restrict the launch of replace brick heal
Problem: When features.cache-invalidation is ON, a lot of
ec_notify function gets called which leads to launch of
too many heals. This leads to no heal completion,
which causes accumulation of heals.
Solution: ec_launch_replace_heal should not be launch
for every event. Replace brick will trigger a child up
event and then only this heal function should be called.
Change-Id: I57b44c6a279d57230daea1d93229be6069245b7d
BUG: 1342796
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
Reviewed-on: http://review.gluster.org/14649
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Diffstat (limited to 'xlators')
-rw-r--r-- | xlators/cluster/ec/src/ec.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/xlators/cluster/ec/src/ec.c b/xlators/cluster/ec/src/ec.c index ab26e882a2e..c803ebfa796 100644 --- a/xlators/cluster/ec/src/ec.c +++ b/xlators/cluster/ec/src/ec.c @@ -519,7 +519,8 @@ unlock: } if (ec->shd.iamshd && - ec->xl_notify_count == ec->nodes) { + ec->xl_notify_count == ec->nodes && + event == GF_EVENT_CHILD_UP) { ec_launch_replace_heal (ec); } out: |