summaryrefslogtreecommitdiffstats
path: root/xlators
diff options
context:
space:
mode:
authorKaleb S. KEITHLEY <kkeithle@redhat.com>2016-11-18 10:05:12 -0500
committerKaleb KEITHLEY <kkeithle@redhat.com>2017-02-26 14:15:14 -0500
commit4638dfc1fee80f9338f2941f3cccb17bec63989a (patch)
tree7955fb0600daaa6b71bf099c4371d7548b2437bc /xlators
parentece5f66a3d05628bb1a74833ae695443e079f80d (diff)
events: use attribute(format(/printf)) to catch fmt string errors
and statedump too. Also "const char *" (versus just "char *") for the fmt param. Change-Id: Ic63734a673208a2cd49aebccce7659816e6179e3 BUG: 1399196 Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com> Reviewed-on: https://review.gluster.org/15881 Smoke: Gluster Build System <jenkins@build.gluster.org> NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org> CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Diffstat (limited to 'xlators')
-rw-r--r--xlators/debug/io-stats/src/io-stats.c4
-rw-r--r--xlators/performance/write-behind/src/write-behind.c2
2 files changed, 3 insertions, 3 deletions
diff --git a/xlators/debug/io-stats/src/io-stats.c b/xlators/debug/io-stats/src/io-stats.c
index 7d33c06b680..d3b3136d982 100644
--- a/xlators/debug/io-stats/src/io-stats.c
+++ b/xlators/debug/io-stats/src/io-stats.c
@@ -3727,7 +3727,7 @@ io_priv (xlator_t *this)
max = conf->cumulative.latency[i].max;
avg = conf->cumulative.latency[i].avg;
- gf_proc_dump_build_key (key, key_prefix_cumulative,
+ gf_proc_dump_build_key (key, key_prefix_cumulative, "%s",
(char *)gf_fop_list[i]);
gf_proc_dump_write (key,"%"PRId64",%"PRId64",%.03f,%.03f,%.03f",
@@ -3739,7 +3739,7 @@ io_priv (xlator_t *this)
max = conf->incremental.latency[i].max;
avg = conf->incremental.latency[i].avg;
- gf_proc_dump_build_key (key, key_prefix_incremental,
+ gf_proc_dump_build_key (key, key_prefix_incremental, "%s",
(char *)gf_fop_list[i]);
gf_proc_dump_write (key,"%"PRId64",%"PRId64",%.03f,%.03f,%.03f",
diff --git a/xlators/performance/write-behind/src/write-behind.c b/xlators/performance/write-behind/src/write-behind.c
index 738faea725e..d63c8b5c1d5 100644
--- a/xlators/performance/write-behind/src/write-behind.c
+++ b/xlators/performance/write-behind/src/write-behind.c
@@ -2784,7 +2784,7 @@ __wb_dump_requests (struct list_head *head, char *prefix)
wb_request_t *req = NULL;
list_for_each_entry (req, head, all) {
- gf_proc_dump_build_key (key_prefix, key,
+ gf_proc_dump_build_key (key_prefix, key, "%s",
(char *)gf_fop_list[req->fop]);
gf_proc_dump_add_section(key_prefix);