diff options
author | Susant Palai <spalai@redhat.com> | 2015-12-02 04:59:55 -0500 |
---|---|---|
committer | Raghavendra G <rgowdapp@redhat.com> | 2015-12-16 23:09:48 -0800 |
commit | 692ccdbd4d11311a1967d62227666d2c473ea233 (patch) | |
tree | 3c4b93f4366d2f36988a9b614f7177a4be7bbf94 /xlators | |
parent | b5de382afa8c5777e455c7a376fc4f1f01d782d1 (diff) |
cluster/dht: Handle failure in getxattr
Problem: Currently even if we have received xattrs from any one of
the subvolume, we unwind with error in case the last subvol (which
unwinds) received a negative response.
To handle the case check if any of the subvolume has received
a response and pass it down.
Change-Id: Ia12a1f9671a6764f7550e6dc223324b1039fcc51
BUG: 1287539
Signed-off-by: Susant Palai <spalai@redhat.com>
Reviewed-on: http://review.gluster.org/12845
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Diffstat (limited to 'xlators')
-rw-r--r-- | xlators/cluster/dht/src/dht-common.c | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/xlators/cluster/dht/src/dht-common.c b/xlators/cluster/dht/src/dht-common.c index 9d661441122..39da4323d8e 100644 --- a/xlators/cluster/dht/src/dht-common.c +++ b/xlators/cluster/dht/src/dht-common.c @@ -3001,6 +3001,13 @@ unlock: this_call_cnt = dht_frame_return (frame); out: if (is_last_call (this_call_cnt)) { + + /* If we have a valid xattr received from any one of the + * subvolume, let's return it */ + if (local->xattr) { + local->op_ret = 0; + } + DHT_STACK_UNWIND (getxattr, frame, local->op_ret, op_errno, local->xattr, NULL); } |