diff options
| author | Jeff Darcy <jdarcy@redhat.com> | 2015-10-06 13:19:01 -0400 |
|---|---|---|
| committer | Vijay Bellur <vbellur@redhat.com> | 2015-10-22 22:51:44 -0700 |
| commit | fb2a511493868a9ff0c2926537a4d1d23821ce38 (patch) | |
| tree | 2e99e23b42cc48915d6bf19cc8e235879f2925c9 /xlators | |
| parent | 594a03b030577bf0ed6960199e920cc5fa7e7afc (diff) | |
libglusterfs: replace default functions with generated versions
Replacing repetitive code like this with code generated from a more
compact "canonical" definition carries several advantages.
* Ease the process of adding new fops (e.g. GF_FOP_IPC).
* Ease the process of making global changes to existing fops (e.g.
adding "xdata").
* Ensure strict consistency between all of the pieces that must be
compatible with each other, through both kinds of changes.
What we have right now is just a start. The above benefits will only
truly be realized when we use the same definitions to generate stubs,
syncops, and perhaps even parts of gfapi or glupy.
This same infrastructure can also be used to reduce code duplication and
potential for error in many of our translators. NSR already uses a
similar technique, using a few hundred lines of templates to generate a
few *thousand* lines of code. The ability to make a global "aspect"
change (e.g. to quorum checking) in one place instead of seventy has
already been demonstrated there.
Other candidates for code generation include the AFR/EC transaction
infrastructure, or stub creation/resumption in io-threads.
Change-Id: If7d59de7a088848b557f5aea00741b4fe19017c1
BUG: 1271325
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/9411
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Diffstat (limited to 'xlators')
| -rw-r--r-- | xlators/cluster/afr/src/pump.c | 2 | ||||
| -rw-r--r-- | xlators/mgmt/glusterd/src/glusterd-handler.c | 1 |
2 files changed, 1 insertions, 2 deletions
diff --git a/xlators/cluster/afr/src/pump.c b/xlators/cluster/afr/src/pump.c index d68947979e1..ef299ec5855 100644 --- a/xlators/cluster/afr/src/pump.c +++ b/xlators/cluster/afr/src/pump.c @@ -14,7 +14,7 @@ #include <fnmatch.h> #include "afr-common.c" -#include "defaults.c" +#include "defaults.h" #include "glusterfs.h" #include "pump.h" #include "afr-messages.h" diff --git a/xlators/mgmt/glusterd/src/glusterd-handler.c b/xlators/mgmt/glusterd/src/glusterd-handler.c index 3494585e7e9..b01a70d62c4 100644 --- a/xlators/mgmt/glusterd/src/glusterd-handler.c +++ b/xlators/mgmt/glusterd/src/glusterd-handler.c @@ -43,7 +43,6 @@ #include <sys/resource.h> #include <inttypes.h> -#include "defaults.c" #include "common-utils.h" #include "globals.h" |