diff options
Diffstat (limited to 'xlators/storage/posix/src/posix-inode-handle.h')
| -rw-r--r-- | xlators/storage/posix/src/posix-inode-handle.h | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/xlators/storage/posix/src/posix-inode-handle.h b/xlators/storage/posix/src/posix-inode-handle.h index 33d908fa3de..cb315424dd0 100644 --- a/xlators/storage/posix/src/posix-inode-handle.h +++ b/xlators/storage/posix/src/posix-inode-handle.h @@ -54,14 +54,18 @@ var = NULL; \ } while (0) +/* TODO: it is not a good idea to change a variable which + is not passed to the macro.. Fix it later */ #define MAKE_INODE_HANDLE(rpath, this, loc, iatt_p) do { \ if (!this->private) { \ + op_ret = -1; \ gf_msg ("make_inode_handle", GF_LOG_ERROR, 0, \ P_MSG_INODE_HANDLE_CREATE, \ "private is NULL, fini is already called"); \ break; \ } \ if (gf_uuid_is_null (loc->gfid)) { \ + op_ret = -1; \ gf_msg (this->name, GF_LOG_ERROR, 0, \ P_MSG_INODE_HANDLE_CREATE, \ "null gfid for path %s", (loc)->path); \ |