summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* mgmt/glusterd: remove debug messages in cleanup_and_exitPranith K2010-09-302-3/+2
| | | | | | | | Signed-off-by: Pranith Kumar K <pranithk@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1746 (volume delete fails after volume stop) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1746
* protocol/client: handle more NULL dereferenceAmar Tumballi2010-09-301-43/+50
| | | | | | | | Signed-off-by: Amar Tumballi <amar@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1745 () URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1745
* protocol/server: set 'this->private' only if 'init()' is successfulAmar Tumballi2010-09-291-2/+1
| | | | | | | | | | | | | If volume file is fetched (due to HUP or volume file changes) and server init is called again, server protocol init fails with 'bind to port failed' error. If 'this->private' is set to new 'conf' before successful init, the whole process goes to corrupted state. Signed-off-by: Amar Tumballi <amar@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 971 (dynamic volume management) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
* replicate: remove checks which prevented self-heal when open fds were presentAnand Avati2010-09-292-16/+1
| | | | | | | | | | | | | this check is not needed anymore since the introduction of changelog piggybacking as the optimization technique instead of first-write-to-flush technique some of the self-healing issues with NFS mounts should be resolved Signed-off-by: Anand V. Avati <avati@amp.gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1235 (Bug for all pump/migrate commits) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1235
* replicate: keep read_child in inode ctx as up-to-date as possibleAnand Avati2010-09-293-4/+50
| | | | | | | | | | | | | In every transaction check if the currently set read child in the inode context failed in the fop and set it to another subvol on which the latest fop has passed. This will prevent read fops landing on subvols which have witnessed a failure. Signed-off-by: Anand V. Avati <avati@amp.gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1172 (ls -lh on NFS mount of 2-mirror replicate gives incorrect file size) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1172
* pump: skip "." and ".." entries while traversing dir treeAnand Avati2010-09-291-0/+4
| | | | | | | | Signed-off-by: Anand V. Avati <avati@amp.gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1235 (Bug for all pump/migrate commits) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1235
* mgmt/glusterd: resolve uuid if nullPranith K2010-09-291-0/+5
| | | | | | | | Signed-off-by: Pranith Kumar K <pranithk@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1734 (replace brick should accept both ipaddress and hostname for bricks) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1734
* glusterd: make sure init is not called when there is no topology changeKaushik BV2010-09-292-9/+27
| | | | | | | | Signed-off-by: Kaushik BV <kaushikbv@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1159 () URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1159
* mgmt/glusterd: set the error before starting checksPranith K2010-09-291-0/+1
| | | | | | | | Signed-off-by: Pranith Kumar K <pranithk@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1734 (replace brick should accept both ipaddress and hostname for bricks) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1734
* mgmt/glusterd: volume start forcePranith K2010-09-2915-291/+317
| | | | | | | | Signed-off-by: Pranith Kumar K <pranithk@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1736 (implement volume start force) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1736
* storage/posix: prevent chmod() from getting called on symlinksAnand Avati2010-09-291-6/+25
| | | | | | | | | | | | symlinks, if at all their mode can be changed (on non-linux platforms) can only be done via lchmod(). Attempting chmod on a symlink can be disastrous. Signed-off-by: Anand V. Avati <avati@amp.gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 881 (GlusterFS daemon hangs on replication of symlink (3.0.4)) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=881
* features/quiesce: new translatorAmar Tumballi2010-09-298-1/+1660
| | | | | | | | | | | | | | | | | 'Quiesce' is used to describe pausing or altering the state of running processes on a computer In GlusterFS context, this translator looks for CHILD_DOWN/CHILD_UP events, and will hold the requests for some time if the child node is in disconnected state current timeout is 20seconds, will be made tunable soon Signed-off-by: Amar Tumballi <amar@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1500 (Mount point should not be in-accessible between reconnect to server) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1500
* defaults.{c,h}: _resume functions addedAmar Tumballi2010-09-292-1166/+1340
| | | | | | | | | | | * cleaned up whitespace * untabify Signed-off-by: Amar Tumballi <amar@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1500 (Mount point should not be in-accessible between reconnect to server) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1500
* replicate: clear pre_op_done/piggyback values after open fd self-healAnand Avati2010-09-291-2/+11
| | | | | | | | Signed-off-by: Anand V. Avati <avati@amp.gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1235 (Bug for all pump/migrate commits) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1235
* replicate: use new style (un)locking in self heal of missing entriesAnand Avati2010-09-291-62/+5
| | | | | | | | Signed-off-by: Anand V. Avati <avati@amp.gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 960 () URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=960
* replicate: replace first-write-to-flush optimizationAnand V. Avati2010-09-296-594/+422
| | | | | | | | | | | | use a changelog piggybacking optimization instead of first-write-to-flush optimization and do other cleanups (removal of post-post-op hook etc.) Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com> Signed-off-by: Anand V. Avati <avati@amp.gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1235 (Bug for all pump/migrate commits) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1235
* whitespace cleanupAnand V. Avati2010-09-294-1928/+1937
| | | | | | | | | Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com> Signed-off-by: Anand V. Avati <avati@amp.gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1235 (Bug for all pump/migrate commits) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1235
* mgmt/glusterd: brick info get should compare uuid instead of hostnamePranith K2010-09-281-3/+6
| | | | | | | | Signed-off-by: Pranith Kumar K <pranithk@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1734 (replace brick should accept both ipaddress and hostname for bricks) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1734
* rpc-clnt: handle NULL dereferencesAmar Tumballi2010-09-281-7/+11
| | | | | | | | Signed-off-by: Amar Tumballi <amar@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1723 () URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1723
* client-handshake: prevent NULL dereferenceAmar Tumballi2010-09-281-11/+33
| | | | | | | | Signed-off-by: Amar Tumballi <amar@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1720 () URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1720
* resolver: set safer conditionals during path creationAnand Avati2010-09-281-1/+1
| | | | | | | | | | | | when client would send just the path as part of a transaction, path reconstruction would create parent directory's path instead of actual path at the time of resolution. Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 935 (Directories change mode from 0755 to 0644 automatically) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=935
* mgmt/glusterd: Fix incorrect state machine transitionv3.1.0qa35Vijay Bellur2010-09-281-1/+1
| | | | | | | | Signed-off-by: Vijay Bellur <vijay@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 971 (dynamic volume management) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
* mgmt/glusterd: compute cksum upon volume retrievalVijay Bellur2010-09-281-7/+12
| | | | | | | | Signed-off-by: Vijay Bellur <vijay@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 971 (dynamic volume management) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
* mgmt/glusterd: prevent cleanup_and_exit if its already startedPranith K2010-09-282-1/+8
| | | | | | | | Signed-off-by: Pranith Kumar K <pranithk@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1706 () URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1706
* Changing readdir calls to readdirp calls in DHTshishir gowda2010-09-282-21/+12
| | | | | | | | | | | | Changing readdir calls to readdirp calls to handle layout issues seen in dht. Also, changing posix readdir call to do stat after dir read for readdirp. Signed-off-by: shishir gowda <shishirng@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1690 () URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1690
* more proper error returns in case of graph topology validationAmar Tumballi2010-09-283-18/+8
| | | | | | | | Signed-off-by: Amar Tumballi <amar@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 971 (dynamic volume management) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
* nfs: Free inodes layer fop locals to fix memory leakShehjar Tikoo2010-09-281-10/+18
| | | | | | | | Signed-off-by: Shehjar Tikoo <shehjart@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1259 (Memory leaks to 5.7g usage in gnfs) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1259
* change the loglevel from error to debug while reconfiguringRaghavendra Bhat2010-09-281-1/+1
| | | | | | | | Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1729 () URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1729
* distribute: Propagate -1 op_ret on failed fopShehjar Tikoo2010-09-281-0/+1
| | | | | | | | Signed-off-by: Shehjar Tikoo <shehjart@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1717 (dht_attr_cbk does not propagate op_ret on failed fop causing nfs crash) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1717
* do not allow remove brick if the total bricks given is less than the sub_countRaghavendra Bhat2010-09-281-6/+18
| | | | | | | | Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1713 () URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1713
* access-control: report possible errors in graph during 'init()'Amar Tumballi2010-09-281-1/+17
| | | | | | | | Signed-off-by: Amar Tumballi <amar@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1712 (Error is not logged for a dangling volume) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1712
* glusterd: logs is a symlink to default var log dirAmar Tumballi2010-09-283-4/+5
| | | | | | | | Signed-off-by: Amar Tumballi <amar@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1728 (glusterd log file location) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1728
* unref the dict allocated in set_volume, remove_brickRaghavendra Bhat2010-09-281-0/+7
| | | | | | | | Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1726 () URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1726
* Starting/stoppin glusterd changes brick pairsshishir gowda2010-09-281-15/+64
| | | | | | | | | | | | | the problem was the pair information was not maintained anywhere. When glusterd re-starts, it reads the brick dir entries and populates the brick list. adding brick info to volume info file to fix this issue Signed-off-by: shishir gowda <shishirng@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1714 () URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1714
* mgmt/glusterd: prevent detach of peer with its bricks existing in clusterPranith K2010-09-287-111/+266
| | | | | | | | Signed-off-by: Pranith Kumar K <pranithk@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1681 () URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1681
* distribute: don't check for inode's gfid in _cbkv3.1.0qa34Amar Tumballi2010-09-271-2/+1
| | | | | | | | | | | | * in dht_lookup_dir_cbk(), at the entry itself we are dereferencing local->inode, which can be NULL in many cases. Hence no need to check/dereference that variable. Just check 'local->gfid'. Signed-off-by: Amar Tumballi <amar@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1696 () URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1696
* replace brick fixesPavan Sondur2010-09-278-253/+395
| | | | | | | | | | | | | | | | | Reviewed ok. Just like commit, maybe we can move 'pause' also to the commit op of replace brick since it can be performed only when replace brick has been started. I'll send in a patch for that soon. ----- Original Message ----- From: "Vijay Bellur" <vijay@gluster.com> To: glusterfs@dev.gluster.com Sent: Monday, September 27, 2010 7:59:25 PM Subject: [PATCH BUG:1235] replace brick fixes Signed-off-by: Vijay Bellur <vijay@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1235 (Bug for all pump/migrate commits) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1235
* glusterfsd: after volume fetch, return proper values from functionsAmar Tumballi2010-09-271-2/+2
| | | | | | | | Signed-off-by: Amar Tumballi <amar@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 971 (dynamic volume management) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
* io-threads: fix NULL dereference in 'reconfigure()'Amar Tumballi2010-09-271-6/+5
| | | | | | | | Signed-off-by: Amar Tumballi <amar@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1715 () URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1715
* mgmt/glusterd: delay probe till connection happensPranith K2010-09-2710-178/+226
| | | | | | | | Signed-off-by: Pranith Kumar K <pranithk@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1607 () URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1607
* access-control: handle a case of wrong error handlingAmar Tumballi2010-09-271-1/+1
| | | | | | | | | | | in rename_src_stat_cbk(), we were checking the return value as '-1', but the function can return '-EFAULT' (ie, -14 in few cases). Signed-off-by: Amar Tumballi <amar@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1691 () URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1691
* fix a build warning about stack overflowAmar Tumballi2010-09-271-12/+12
| | | | | | | | Signed-off-by: Amar Tumballi <amar@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1710 (build warning) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1710
* mgmt/glusterd: perform post operations of volume setPranith K2010-09-271-5/+12
| | | | | | | | Signed-off-by: Pranith Kumar K <pranithk@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1708 (update store, re-compute checksum, restart nfs for volume set) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1708
* protocol/server: Check before de-referencing confVijay Bellur2010-09-271-0/+4
| | | | | | | | Signed-off-by: Vijay Bellur <vijay@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1698 () URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1698
* nfs: Fix multiple subvolume CHILD-UP supportv3.1.0qa33Shehjar Tikoo2010-09-251-0/+1
| | | | | | | | Signed-off-by: Shehjar Tikoo <shehjart@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1643 (Initial requests after mount ESTALE if DHT subvolumes connect after nfs startup) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1643
* mgmt/glusterd: Do not look into brick when logfile is being set for volumeVijay Bellur2010-09-251-8/+6
| | | | | | | | Signed-off-by: Vijay Bellur <vijay@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 971 (dynamic volume management) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
* mgmt/glusterd: resolve brick before doing uuid comparev3.1.0qa32Vijay Bellur2010-09-241-0/+14
| | | | | | | | Signed-off-by: Vijay Bellur <vijay@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 971 (dynamic volume management) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
* glusterd: add new stats related options for 'volume set'Amar Tumballi2010-09-243-5/+27
| | | | | | | | | | | * 'gluster volume set <VOLNAME> latency-measurement <yes|no>' * 'gluster volume set <VOLNAME> dump-fd-stats <yes|no>' Signed-off-by: Amar Tumballi <amar@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1701 (better statistics gathering in glusterd) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1701
* glusterd-volgen: add 'io-stats' xlator on server volfile tooAmar Tumballi2010-09-241-9/+23
| | | | | | | | Signed-off-by: Amar Tumballi <amar@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1701 (better statistics gathering in glusterd) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1701
* io-stats: bring in latency measurement featureAmar Tumballi2010-09-241-3/+232
| | | | | | | | Signed-off-by: Amar Tumballi <amar@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1701 (better statistics gathering in glusterd) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1701