summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* syncdaemon: streamline user-visible messages (and control flow a bit, too)Csaba Henk2011-04-132-11/+11
| | | | | | | | Signed-off-by: Csaba Henk <csaba@gluster.com> Signed-off-by: Anand Avati <avati@gluster.com> BUG: 2644 (no volume-mark, if the behaviour persists have to check if master gsyncd is running.) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2644
* syncdaemon: fix parsing of the volume-mark structureCsaba Henk2011-04-131-1/+1
| | | | | | | | | | | The parsing error implied that all xtimes were considered to be valid, regardless of the volume mark. Signed-off-by: Csaba Henk <csaba@gluster.com> Signed-off-by: Anand Avati <avati@gluster.com> BUG: 2535 (gsync cascading) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2535
* syncdaemon: return exit code properlyCsaba Henk2011-04-131-3/+6
| | | | | | | | Signed-off-by: Csaba Henk <csaba@gluster.com> Signed-off-by: Anand Avati <avati@gluster.com> BUG: 1570 (geosync related changes) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1570
* syncdaemon: fix pidfile deletion on failed pidfile acquisitionCsaba Henk2011-04-131-1/+6
| | | | | | | | | | | (not triggered in glusterd instrumentation of gsyncd as glusterd does pidfile probing by itself) Signed-off-by: Csaba Henk <csaba@gluster.com> Signed-off-by: Anand Avati <avati@gluster.com> BUG: 1570 (geosync related changes) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1570
* syncdaemon: minor fixesCsaba Henk2011-04-133-4/+2
| | | | | | | | | | | - whitespace fix - remove superfluous imports Signed-off-by: Csaba Henk <csaba@gluster.com> Signed-off-by: Anand Avati <avati@gluster.com> BUG: 1570 (geosync related changes) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1570
* mgmt/glusterd: Remove excessive INFO logsPranith Kumar K2011-04-132-3/+10
| | | | | | | | Signed-off-by: Pranith Kumar K <pranithk@gluster.com> Signed-off-by: Anand Avati <avati@gluster.com> BUG: 2346 (Log message enhancements in GlusterFS - phase 1) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2346
* mgmt/glusterd: log stats commands to cmd logPranith Kumar K2011-04-131-0/+5
| | | | | | | | Signed-off-by: Pranith Kumar K <pranithk@gluster.com> Signed-off-by: Anand Avati <avati@gluster.com> BUG: 2735 (log stats commands (top/profile) to cmd log) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2735
* mgmt/glusterd: volume reset force implementationPranith Kumar K2011-04-136-94/+161
| | | | | | | | Signed-off-by: Pranith Kumar K <pranithk@gluster.com> Signed-off-by: Anand Avati <avati@gluster.com> BUG: 2729 (Implement force option for volume reset) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2729
* features/quota: update quota-limit stored in directory contexts after ↵Raghavendra G2011-04-131-0/+4
| | | | | | | | | | reconfigure. Signed-off-by: Raghavendra G <raghavendra@gluster.com> Signed-off-by: Anand Avati <avati@gluster.com> BUG: 2604 (Quota: crossing the set limit) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2604
* features/marker: Filter the quota xattr's on getxattr with NULL name argument.Junaid2011-04-133-2/+36
| | | | | | | | Signed-off-by: Junaid <junaid@gluster.com> Signed-off-by: Anand Avati <avati@gluster.com> BUG: 2473 (Support for volume and directory level quota) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2473
* features/marker: Call update txn when the directory size and its ↵Junaid2011-04-131-1/+8
| | | | | | | | | | contribution are not same. Signed-off-by: Junaid <junaid@gluster.com> Signed-off-by: Anand Avati <avati@gluster.com> BUG: 2473 (Support for volume and directory level quota) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2473
* remove excessive logs due to log enhancementAmar Tumballi2011-04-137-21/+38
| | | | | | | | Signed-off-by: Amar Tumballi <amar@gluster.com> Signed-off-by: Anand Avati <avati@gluster.com> BUG: 2346 (Log message enhancements in GlusterFS - phase 1) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2346
* script: fix the typo while doing replace brickRaghavendra Bhat2011-04-131-1/+1
| | | | | | | | Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com> Signed-off-by: Anand Avati <avati@gluster.com> BUG: 1436 (script for running basic gluster commands) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1436
* declare favorite child as int instead of unsigned intRaghavendra Bhat2011-04-131-1/+1
| | | | | | | | | | | | | | In afr_private_t structure favorite child is declared as unsigned int. In init function of afr we set favorite child to -1, if that option is not found in volfile. But favorite child value will be set to a huge value instead of -1 since it is an unsigned int and in statedump file favorite child value is displayed as a huge value instead of -1. Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com> Signed-off-by: Anand Avati <avati@gluster.com> BUG: 2668 ([glusterfs-3.2.9qa7]: createbench error) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2668
* libglusterfs: Check for null dereference in statedumpVijay Bellur2011-04-121-1/+2
| | | | | | | | Signed-off-by: Vijay Bellur <vijay@gluster.com> Signed-off-by: Anand Avati <avati@gluster.com> BUG: 2731 (coredump when process state dump command is issued immediately after mounting fuse client) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2731
* cli: Fix typo in top help stringPranith Kumar K2011-04-121-1/+1
| | | | | | | | Signed-off-by: Pranith Kumar K <pranithk@gluster.com> Signed-off-by: Anand Avati <avati@gluster.com> BUG: 2719 (Incorrect help string for volume top) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2719
* features/quota: check for proper return value in case failure of dict_get_binRaghavendra G2011-04-121-1/+1
| | | | | | | | Signed-off-by: Raghavendra G <raghavendra@gluster.com> Signed-off-by: Anand Avati <avati@gluster.com> BUG: 2723 ([glusterfs-3.2.0qa11]: glusterfs client crashed in quota_validate_cbk) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2723
* features/quota: add error checks for failure of quota_inode_loc_fill.Raghavendra G2011-04-121-8/+34
| | | | | | | | Signed-off-by: Raghavendra G <raghavendra@gluster.com> Signed-off-by: Anand Avati <avati@gluster.com> BUG: 2727 ([glusterfs-3.2.0qa11]: nfs server crashed in quota_check_limit) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2727
* quota: assign frame->local to local before checking op_retRaghavendra Bhat2011-04-121-1/+2
| | | | | | | | Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com> Signed-off-by: Anand Avati <avati@gluster.com> BUG: 2733 ([glusterfs-3.2.0qa11]: nfs server crashed) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2733
* features/quota: Validate the quota options. and donot include into the ↵Junaid2011-04-121-0/+28
| | | | | | | | | | client volfile. Signed-off-by: Junaid <junaid@gluster.com> Signed-off-by: Anand Avati <avati@gluster.com> BUG: 2541 (insufficient option validation in quota translator) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2541
* features/marker: Adding NULL checks.Junaid2011-04-124-27/+35
| | | | | | | | Signed-off-by: Junaid <junaid@gluster.com> Signed-off-by: Anand Avati <avati@gluster.com> BUG: 2473 (Support for volume and directory level quota) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2473
* protocol/client: convert to errno before checking for EAGAINAmar Tumballi2011-04-121-5/+10
| | | | | | | | | | | in *lk_cbk() functions. Network error code may be different than what is actual errno code. Signed-off-by: Amar Tumballi <amar@gluster.com> Signed-off-by: Anand Avati <avati@gluster.com> BUG: 2346 (Log message enhancements in GlusterFS - phase 1) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2346
* protocol/client: fix the fd_count decrement logicAmar Tumballi2011-04-121-3/+5
| | | | | | | | | | the error creeped in during some code cleanup and logging enhancement Signed-off-by: Amar Tumballi <amar@gluster.com> Signed-off-by: Anand Avati <avati@gluster.com> BUG: 1761 (incorrect self-heal behaviour when files are deleted) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1761
* temporary workaround for mtab update race thingyCsaba Henk2011-04-124-0/+6
| | | | | | | | Signed-off-by: Csaba Henk <csaba@gluster.com> Signed-off-by: Anand Avati <avati@gluster.com> BUG: 2690 (race between mtab updates of mount and umount) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2690
* libglusterfs/dict: Donot perform NULL check on data in dict_foreachJunaid2011-04-121-2/+2
| | | | | | | | Signed-off-by: Junaid <junaid@gluster.com> Signed-off-by: Anand Avati <avati@gluster.com> BUG: 1816 (send volume options in friend add) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1816
* mgmt/glusterd: Mount a maintainance client only on the glusterd which ↵Junaid2011-04-121-2/+2
| | | | | | | | | | received quota enable through cli. Signed-off-by: Junaid <junaid@gluster.com> Signed-off-by: Anand Avati <avati@gluster.com> BUG: 2473 (Support for volume and directory level quota) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2473
* build fixesVenky Shankar2011-04-118-36/+78
| | | | | | | | Signed-off-by: Venky Shankar <venky@gluster.com> Signed-off-by: Anand Avati <avati@gluster.com> BUG: 2550 (build warnings) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2550
* mgmt/glusterd: Fix warning in glusterd buildPranith Kumar K2011-04-111-0/+1
| | | | | | | | Signed-off-by: Pranith Kumar K <pranithk@gluster.com> Signed-off-by: Anand Avati <avati@gluster.com> BUG: 2718 (Fix warning in glusterd build) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2718
* libglusterfs/src: bring in VALIDATE_OR_GOTO to argsAmar Tumballi2011-04-112-128/+183
| | | | | | | | | | | so we can capture places which are calling these function with invalid arguments Signed-off-by: Amar Tumballi <amar@gluster.com> Signed-off-by: Anand Avati <avati@gluster.com> BUG: 2346 (Log message enhancements in GlusterFS - phase 1) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2346
* mgmt/glusterd: Quota client lazy umount.v3.2.0qa11Junaid2011-04-111-32/+77
| | | | | | | | Signed-off-by: Junaid <junaid@gluster.com> Signed-off-by: Anand Avati <avati@gluster.com> BUG: 2560 (Lazy umount should be done for the maintainance mode mountpoint) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2560
* mgmt/Glusterd: Do not disable marker on gsync stop.Kaushik BV2011-04-111-30/+30
| | | | | | | | Signed-off-by: Kaushik BV <kaushikbv@gluster.com> Signed-off-by: Anand Avati <avati@gluster.com> BUG: 2559 (provide two options in CLI for gluster volume gsync indexing <volname> <enable|disable>) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2559
* features/quota: Adding the option "timeout" to quota.Junaid2011-04-112-1/+23
| | | | | | | | | | This option tells the quota translator when to perform the next aggregation. Signed-off-by: Junaid <junaid@gluster.com> Signed-off-by: Anand Avati <avati@gluster.com> BUG: 2473 (Support for volume and directory level quota) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2473
* syncdaemon: do not use os.getlogin() for getting the name of the current userCsaba Henk2011-04-111-1/+2
| | | | | | | | | | This function relies on the terminal (cf. getlogin(3)), which is not available if we run as daemon Signed-off-by: Csaba Henk <csaba@gluster.com> Signed-off-by: Anand Avati <avati@gluster.com> BUG: 2712 (username resolution in gsyncd fails) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2712
* mgmt/Glusterd: logging of few commands in cmd_log_historyKaushik BV2011-04-111-1/+113
| | | | | | | | Signed-off-by: Kaushik BV <kaushikbv@gluster.com> Signed-off-by: Anand Avati <avati@gluster.com> BUG: 2449 ([glusterfs-3.2.0-cisco1]: gsync commands are not logged in the cmd_log_history) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2449
* marker: check the return value being less than zero instead of -1Raghavendra Bhat2011-04-111-1/+3
| | | | | | | | Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com> Signed-off-by: Anand Avati <avati@gluster.com> BUG: 2711 ([glusterfs-3.2.0qa10]: glusterfs server crashed in marker_setxattr operations) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2711
* features/quota: handle failed fops gracefully.Raghavendra G2011-04-111-11/+39
| | | | | | | | Signed-off-by: Raghavendra G <raghavendra@gluster.com> Signed-off-by: Anand Avati <avati@gluster.com> BUG: 2701 ([6db2b422f05d0553d0a83af603ae4d176b41cbdf]: crash in quota_readlink_cbk) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2701
* cli: Validating the cli quota options.Junaid2011-04-112-7/+11
| | | | | | | | Signed-off-by: Junaid <junaid@gluster.com> Signed-off-by: Anand Avati <avati@gluster.com> BUG: 2612 (quota limit-set not in line with help) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2612
* features/quota: Add checks for any of the parents of file being NULL while ↵Raghavendra G2011-04-111-0/+11
| | | | | | | | | | checking limits. Signed-off-by: Raghavendra G <raghavendra@gluster.com> Signed-off-by: Anand Avati <avati@gluster.com> BUG: 2685 (nfs server crashed in quota_check_limit) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2685
* features/quota: use signed type to store delta.Raghavendra G2011-04-112-9/+9
| | | | | | | | Signed-off-by: Raghavendra G <raghavendra@gluster.com> Signed-off-by: Anand Avati <avati@gluster.com> BUG: 2604 (Quota: crossing the set limit) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2604
* buf and statpost should be checked for NULL before accessing itRaghavendra Bhat2011-04-111-3/+6
| | | | | | | | Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com> Signed-off-by: Anand Avati <avati@gluster.com> BUG: 2701 ([6db2b422f05d0553d0a83af603ae4d176b41cbdf]: crash in quota_readlink_cbk) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2701
* syncdaemon: fix transaction codeCsaba Henk2011-04-112-7/+7
| | | | | | | | Signed-off-by: Csaba Henk <csaba@gluster.com> Signed-off-by: Anand Avati <avati@gluster.com> BUG: 2659 (gsync config-del option is not working properly) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2659
* syncdaemon: minor fixesCsaba Henk2011-04-112-3/+3
| | | | | | | | | | | | - fix yet another instance of calling exit (instead of {sys.,os._}exit) - fix logging to stderr with "-" as logfile - whitespace fix Signed-off-by: Csaba Henk <csaba@gluster.com> Signed-off-by: Anand Avati <avati@gluster.com> BUG: 1570 (geosync related changes) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1570
* syncdaemon: fix setting None as new masterCsaba Henk2011-04-111-5/+6
| | | | | | | | | | | | | | | | | | | | | | | | | We checked for the event of a new master being adopted by: - checking for state change in list of masters - checking if our chosen master is a foreign one and if these held, then wrote out the actually available master to config However this was flaky: if (1) native master changed (2) there was already a foreign master adopted (3) actually the master was not available then we wrote out the None to config. This could occur if: - on syncd startup, native master just changes from None to the volume native [implies (1)] - foreign master adopted from earlier run via config [implies (2)] - actually foreign master was not available [implies (3)] Signed-off-by: Csaba Henk <csaba@gluster.com> Signed-off-by: Anand Avati <avati@gluster.com> BUG: 2670 (strange behaviour with intermediate-master and slave) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2670
* protocol/server: prevent unnessary logs in INFO levelAmar Tumballi2011-04-101-10/+11
| | | | | | | | | | 'op_ret == 0' in readdir() is a valid return code. Signed-off-by: Amar Tumballi <amar@gluster.com> Signed-off-by: Anand Avati <avati@gluster.com> BUG: 2346 (Log message enhancements in GlusterFS - phase 1) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2346
* cluster/distribute: Account for the first lookup sent to check whether the ↵Raghavendra G2011-04-101-1/+15
| | | | | | | | | | | | | | | path is a directory while aggregating quota-xattrs. - The total number of lookups sent for a directory is equal to (no of children + 1). Hence we should not aggregate the xattrs from the first lookup. Signed-off-by: Raghavendra G <raghavendra@gluster.com> Signed-off-by: Junaid <junaid@gluster.com> Signed-off-by: Anand Avati <avati@gluster.com> BUG: 2604 (Quota: crossing the set limit) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2604
* cli: Cleanup the maintainence mount points used by quota.Junaid2011-04-101-31/+38
| | | | | | | | Signed-off-by: Junaid <junaid@gluster.com> Signed-off-by: Anand Avati <avati@gluster.com> BUG: 2704 (Stale mount-points seen after execting quota list command) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2704
* marker/quota: use correct byte order while storing xattr values in backend.Raghavendra G2011-04-101-1/+1
| | | | | | | | Signed-off-by: Junaid <junaid@gluster.com> Signed-off-by: Anand Avati <avati@gluster.com> BUG: 2604 (Quota: crossing the set limit) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2604
* features/quota: Fix race-condition while resuming stub.Raghavendra G2011-04-102-38/+87
| | | | | | | | | | | | | | | | | | - call-stub is resumed in fops calling quota_check_limit and quota_check_limit when validate_count is zero, indicating no pending validates. During validates, validate_count was decremented in quota_validate_cbk, but check for validate_count being zero was done in quota_check_limit (which is called by quota_validate_cbk). Hence there is a time window b/w decrementing validate_count in quota_validate_cbk and checking whether validate_count is zero in quota_check_limit, during which if the control is passed to code in fop checking for validate_count being zero, same stub will be resumed twice - once in fop and once in quota_check_limit. Signed-off-by: Raghavendra G <raghavendra@gluster.com> Signed-off-by: Anand Avati <avati@gluster.com> BUG: 2686 ([glusterfs-3.2.0qa8]: nfs server crashed) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2686
* DHT: send revalidate to all subvols and not just first subvolshishir gowda2011-04-101-6/+10
| | | | | | | | | | | Reverting commit 23d9783a192669b638d42b8dd127ad69ea36f950. When first subvolume is down, mount point becomes inaccessible. Signed-off-by: shishir gowda <shishirng@gluster.com> Signed-off-by: Anand Avati <avati@gluster.com> BUG: 2532 ([glusterfs-3.1.3qa8]: bringing first subvolume down makes mount point inaccessible) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2532
* libglusterfs/xlator: set THIS properly whenever some operation is done ↵Raghavendra G2011-04-101-7/+26
| | | | | | | | | | iteratively on more than one xlator in the graph. Signed-off-by: Raghavendra G <raghavendra@gluster.com> Signed-off-by: Anand Vishweshwaran Avati <avati@shell.gluster.com> BUG: 2683 ([glusterfs-3.2.0qa8]: glusterfs client crashed in reconfigure) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2683