summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* use rpc_clnt_{new,start} (), instead of rpc_clnt_init();Amar Tumballi2011-01-273-5/+16
| | | | | | | | | | | to prevent a race between getting a CONNECT/DISCONNECT event before registering a notify function Signed-off-by: Amar Tumballi <amar@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 2314 (notify function registration in CLI) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2314
* free GF_CALLOCed memory by GF_FREE instead of FREERaghavendra Bhat2011-01-271-2/+2
| | | | | | | | Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 329 (Replacing memory allocation functions with mem-type functions) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=329
* glusterfsd-mgmt: handle the RPC_DISCONNECT event properlyAmar Tumballi2011-01-271-0/+8
| | | | | | | | | | | This patch solves the issue of hanging mount point in case of wrong server name is given during mount command Signed-off-by: Amar Tumballi <amar@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 1453 (mount command didn't give error message) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1453
* remove op_errstr from glusterd_handle_rpc_msg as op_errstr is not used in ↵Raghavendra Bhat2011-01-271-4/+2
| | | | | | | | | | that function Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 1598 ([glusterfs-3.1.0qa22]: crash in glusterd) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1598
* cli: Show 'commit' option in replace-brick.Gaurav2011-01-271-1/+1
| | | | | | | | Signed-off-by: Gaurav <gaurav@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 2273 (replace-brick help does not show commit option) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2273
* adding syncdaemonCsaba Henk2011-01-2713-1/+1217
| | | | | | | | Signed-off-by: Csaba Henk <csaba@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 2310 (georeplication) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2310
* mgmt/glusterd: restart bricks when syncdaemon is enabledKaushik BV2011-01-273-2/+64
| | | | | | | | | Signed-off-by: Kaushik BV <kaushikbv@gluster.com> Signed-off-by: Csaba Henk <csaba@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 2310 (georeplication) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2310
* volgen: add marker to brick volfilesCsaba Henk2011-01-271-5/+94
| | | | | | | | Signed-off-by: Csaba Henk <csaba@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 2310 (georeplication) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2310
* implement "--client-pid" option which can forcibly set the pid value in ↵Csaba Henk2011-01-276-0/+40
| | | | | | | | | | messages to a predefined value Signed-off-by: Csaba Henk <csaba@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 2310 (georeplication) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2310
* adding marker translatorJunaid2011-01-277-3/+1540
| | | | | | | | | Signed-off-by: Junaid <junaid@gluster.com> Signed-off-by: Csaba Henk <csaba@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 2310 (georeplication) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2310
* adding libxlator, to ensure proper client side aggregation of marks by ↵Kaushik BV2011-01-2712-20/+737
| | | | | | | | | | | clustering translators Signed-off-by: Kaushik BV <kaushikbv@gluster.com> Signed-off-by: Csaba Henk <csaba@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 2310 (georeplication) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2310
* rpc: handle proper 'ref', 'unref' of transport from rpc-clntAmar Tumballi2011-01-262-3/+7
| | | | | | | | Signed-off-by: Amar Tumballi <amar@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 2250 ([glusterfs-3.1.2qa2]: SegFault in rpc-clnt.c) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2250
* features/access-control: skip access-tests if the call is from fusePranith K2011-01-264-1/+90
| | | | | | | | | | | | | | Fuse cant send aux gids. So access-control checks treat non-primary-group membership of user as "other". So skip access-control checks if the call is from fuse. We added a hack to treat all calls with pid set to 1 as calls from nfs. So for calls with pid not 1 we skip the access-control checks on all fops. Signed-off-by: Pranith Kumar K <pranithk@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 2296 (svn / subversion fails on gluster volume (replicated and non-replicated)) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2296
* mgmt/glusterd: error out if remove-brick comes for final bricksPranith K2011-01-261-2/+9
| | | | | | | | Signed-off-by: Pranith Kumar K <pranithk@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 2298 (removing the last pair of bricks from a volume results in inconsistency) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2298
* cli: return error when cmd execution failsPranith K2011-01-261-7/+8
| | | | | | | | Signed-off-by: Pranith Kumar K <pranithk@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 2287 (Gluster CLI returns wrong return code.) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2287
* protocol/server: Distinguishing the locks based on the type of fop like ↵Mohammed Junaid Ahmed2011-01-244-50/+141
| | | | | | | | | | | | | | inodelk and entrylk. Currently, the protocol server considers entrylk to be held only on directories and inodelk on files and thus when a client unmounts itself while holding locks, it fails to free entrylk locks held on files and inodelk locks held on directories. Signed-off-by: Junaid <junaid@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 2221 (Failed to free Inodlk locks on directories when the client holding the locks was unmounted before releasing the locks held.) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2221
* glusterd: de-register nfs rpcs when it is stoppedPranith K2011-01-241-1/+31
| | | | | | | | Signed-off-by: Pranith Kumar K <pranithk@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 1783 (kill glusterd and stop the cluster and start again - check nfs process) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1783
* nfs3: Handle root resolution failuresv3.1.2Shehjar Tikoo2011-01-131-9/+9
| | | | | | | | | | | ..to prevent a second reply to the client which results in accessing a call state structure that gets freed on the first reply. Signed-off-by: Shehjar Tikoo <shehjart@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 2286 ([glusterfs 3.1.2qa3]: Crash due to corruption in gf_dirent_free) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2286
* performance/quick-read: Fix unwinding of same frame twice when qr_loc_fill ↵v3.1.2qa4Raghavendra G2011-01-111-42/+22
| | | | | | | | | | fails. Signed-off-by: Raghavendra G <raghavendra@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 2274 (crash in fd_unref) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2274
* mgmt/Glusterd: make nfs.mem-factor settable through CLIKaushik BV2011-01-112-3/+35
| | | | | | | | Signed-off-by: Kaushik BV <kaushikbv@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 2277 (Regression in Gluster NFS re-read performance) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2277
* nfs: Introduce tunable for memory consumptionShehjar Tikoo2011-01-111-1/+27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | NFS has used a common define called the mem-factor to determine how much memory is allocated for the following items: o inode table o local structures used by nfs for storing fop state o local structures used by nfs3 for storing nfs op state These are all allocated through the mem-pool. The factor is multiplied by a multiple that is specific to each data structure. For eg. define GF_NFS_CONCURRENT_OPS_MULT 15 define GF_NFS_INODE_LRU_MULT 6000 The first value is used for allocating a mem-pool for storing state for each fop or nfs op that is currently being handled. Knowing that linux allows at most 128 in-flight requests, this multiple combined with the default mem-factor of 15 gives us 225 slots in the mem-pool for the local structures. Similarly, 6000*15 gives us a space of 90k inodes in the lru. That means, increasing the common mem-factor will allow increasing the perf under some conditions. This patch introduces the mem-factor as a configurable option. Signed-off-by: Shehjar Tikoo <shehjart@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 2277 (Regression in Gluster NFS re-read performance) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2277
* exit if the key or the value is null while retrieving the peer information ↵Raghavendra Bhat2011-01-111-0/+8
| | | | | | | | | | in glusterd_restore Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 2271 ([glusterfs-3.1.2qa3]: entry->hostname in glusterd_friend_find_by_hostname is 0x0) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2271
* Add corresponding va_end.Sachidananda2011-01-071-0/+1
| | | | | | | | Signed-off-by: Sachidananda Urs <sac@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 2247 (Add corresponding va_end) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2247
* cluster/replicate: update st_nlink count of stat sent to application after ↵Raghavendra G2011-01-071-3/+18
| | | | | | | | | | | | | | completion of entry-self-heal. - certain applications like 'find' use st_nlink count to optimize searches. Hence an incorrect hard link count can result in non-healing of some of the newly created subdirectories. Signed-off-by: Raghavendra G <raghavendra@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 2187 (Self heal errors) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2187
* nfs3: Ignore requests for volumes without a single CHILD-UPShehjar Tikoo2011-01-073-42/+78
| | | | | | | | | | | NFS ignores the requests for subvolumes on which child-up has never been received. Signed-off-by: Shehjar Tikoo <shehjart@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 2200 (cp dies with "Invalid argument" after failover) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2200
* check the value of op_ret pointer not the addressRaghavendra Bhat2011-01-071-1/+1
| | | | | | | | Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 221 (stat prefetch implementation) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
* storage/posix: in opendir, allocate proper size for fd ctx pointerAmar Tumballi2011-01-071-1/+1
| | | | | | | | Signed-off-by: Amar Tumballi <amar@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 2280 (wrong size allocated for posix_fd in posix.c:posix_opendir()) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2280
* logging: reintroduce build warning for mismatching format strings and parametersAnand Avati2011-01-061-0/+6
| | | | | | | | | Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com> Signed-off-by: Amar Tumballi <amar@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 2211 ((re)introduce warnings for format string/parameter mismatch) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2211
* logging: fix format warningsAmar Tumballi2011-01-063-15/+15
| | | | | | | | Signed-off-by: Amar Tumballi <amar@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 2211 ((re)introduce warnings for format string/parameter mismatch) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2211
* nfs3: Force root lookup before starting fh resolutionv3.1.2qa3Shehjar Tikoo2010-12-293-7/+127
| | | | | | | | Signed-off-by: Shehjar Tikoo <shehjart@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 2200 (cp dies with "Invalid argument" after failover) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2200
* nfs/server: unrefing inodes on error in nfs_loc_copy ().Mohammed Junaid Ahmed2010-12-291-0/+8
| | | | | | | | Signed-off-by: Junaid <junaid@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 2252 (unreffing of inodes not done when memory allocation fails) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2252
* xlator.c: Unrefing inode's on error in loc_copy.Mohammed Junaid Ahmed2010-12-291-0/+7
| | | | | | | | Signed-off-by: Junaid <junaid@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 2252 (unreffing of inodes not done when memory allocation fails) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2252
* nfs: Support subdirectory exportsShehjar Tikoo2010-12-293-17/+183
| | | | | | | | | | | | | | | | | | Enable exporting directories as separate exports. Even though the directories wont show up in showmount output, they'll still be mount'able. The new option: nfs.export-dirs <on|off> is enabled by default so that users dont have to wait till this option is incorporated into the gluster command line. Signed-off-by: Shehjar Tikoo <shehjart@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 1743 (XenServer is not compatible with GlusterNFS) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1743
* afr_lookup_done: Propogate the same inode number as sent in first lookupshishir gowda2010-12-291-7/+7
| | | | | | | | | If only one subvolume was up, we used to unwind, without updating the ino Signed-off-by: shishir gowda <shishirng@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 2144 (errors removing directories when one subvolume is down) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2144
* stripe: fix memory leakAnand Avati2010-12-292-5/+15
| | | | | | | | | | | destroy the frame copied and clean the local structure in stripe to avoid memory leak Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com> Signed-off-by: Anand V. Avati <avati@amp.gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 2253 (Memory leak in glusterfs) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2253
* quiesce: bring in feature to re-transmit the framesAmar Tumballi2010-12-292-370/+1502
| | | | | | | | | | | | there was a corner case of 'fops' failing if they were in transit during a disconnection, if the failure is due to 'ENOTCONN' re-transmit the frame. Signed-off-by: Amar Tumballi <amar@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 1500 (Mount point should not be in-accessible between reconnect to server) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1500
* change the log level from warning to debug while getting pending matrixRaghavendra Bhat2010-12-271-1/+1
| | | | | | | | Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 1080 (clang errors in the file afr-self-heal-common.c) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1080
* send_fuse_iov: check args to prevent possible NULL dereferencingshishir gowda2010-12-271-0/+4
| | | | | | | | Signed-off-by: shishir gowda <shishirng@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 2223 (Crash in send_fuse_err) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2223
* rdma : prevent confusing logs when both 'poll_in' and 'poll_err' are received.Amar Tumballi2010-12-271-1/+1
| | | | | | | | Signed-off-by: Amar Tumballi <amar@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 875 (Implement a new protocol to provide proper backward/forward compatibility) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=875
* nfs3: Access cbk must account for auxgids on group access checksShehjar Tikoo2010-12-273-6/+23
| | | | | | | | Signed-off-by: Shehjar Tikoo <shehjart@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 2045 (Write permission denied for non-primary group membership) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2045
* nfs: Do not touch iatt on failed fopsShehjar Tikoo2010-12-271-20/+30
| | | | | | | | Signed-off-by: Shehjar Tikoo <shehjart@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 2169 (NFS crash in nfs-fops due to failed fop from subvolume) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2169
* glusterd,cli: print single error message on failurePranith K2010-12-2714-225/+505
| | | | | | | | Signed-off-by: Pranith Kumar K <pranithk@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 1922 (Volume not present wrong message displayed on command line) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1922
* Add volume key to select data-self-heal-algorithmHarshavardhana2010-12-272-11/+56
| | | | | | | | Signed-off-by: Harshavardhana <harsha@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 2218 (Replicate self-heal causes servers to go 100% cpu and unresponsive.) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2218
* log the total rebalance command recieved into the logfileRaghavendra Bhat2010-12-271-2/+3
| | | | | | | | Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 2231 (log the total rebalance command recieved, in the logfile to avoid confusion) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2231
* libglusterfs: data_copy needs to init the lockPranith K2010-12-271-0/+1
| | | | | | | | Signed-off-by: Pranith Kumar K <pranithk@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 2226 (data_copy needs to init the data lock) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2226
* Make STRIPE_STACK_UNWIND and STRIPE_STACK_DESTROY default calls in stripeshishir gowda2010-12-271-74/+54
| | | | | | | | Signed-off-by: shishir gowda <shishirng@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 2134 (inode leaks on stripe) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2134
* Implement STRIPE_STACK_UNWIND and STRIPE_STACK_DESTROYshishir gowda2010-12-271-0/+18
| | | | | | | | Signed-off-by: shishir gowda <shishirng@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 2134 (inode leaks on stripe) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2134
* Remove check for path in stripe_local_wipeshishir gowda2010-12-271-4/+2
| | | | | | | | | | | The check for path is done in loc_wipe. During loc_copy, inode ref is taken before path set succeeds or fails. Signed-off-by: shishir gowda <shishirng@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 2134 (inode leaks on stripe) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2134
* performance/io-threads: implement rchecksum fop.Raghavendra G2010-12-141-0/+52
| | | | | | | | Signed-off-by: Raghavendra G <raghavendra@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 2220 (Implement rchecksum fop) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2220
* setsockopt should be called with solaris specific arguments for solaris servershishir gowda2010-12-141-0/+5
| | | | | | | | | | | | | | | ----- Original Message ----- From: "Raghavendra Bhat" <raghavendrabhat@gluster.com> To: glusterfs@dev.gluster.com Sent: Tuesday, December 14, 2010 11:56:43 AM Subject: [PATCH BUG:2205 v4] setsockopt should be called with solaris specific arguments for solaris server Looks fine to me. Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 2205 ([glusterfs-3.1.2qa1]: error while setting the keepalive time interval) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2205