| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There are several reasons why the behaviour in
the hook scripts was bad:
1. A samba installation is clustered or non-clustered.
That does not change because of the availability
of the CTDB lock-volume. If the lock-volume is not
available (and hence CTDB is not available or not
healthy), then Samba won't be operational. But turning
it into a non-clustered Samba-installation can in
the worst case lead to data corruption if clients
manage to access the same files (on share volumes).
Hence 'clustering = yes/no' in Samba's config should
not be touched.
In particular, Samba should not be stopped/started by
the hook script. If needed, then ctdb will take care
of it.
2. Changing the idmap configuration is potentially
dangerous as well. In particular the used tdb2
backend is legacy nowadays and should not be used
any more in new installs. (I stems from the times
when ctdb could not host persistent databases.)
Changing the idmap can result in loss of access
to files or in giving access to files where it is
not intended.
3. The pattern used for detecting need for change is
fragile. It may or may not play well possible
manual changes to smb.conf.
This change removes the parts that change the smb.conf
file and start or stop Samba from the S29CTDB* hook scripts.
> Change-Id: I72f7aabafa8f089da4531fca2572a72c22825bcc
> BUG: 1290151
> Signed-off-by: Michael Adam <obnox@samba.org>
> Reviewed-on: http://review.gluster.org/12930
> Tested-by: Gluster Build System <jenkins@build.gluster.com>
> Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
(cherry picked from commit 27c16d6da82876a689dfba53b8d45c3a3a657954)
Change-Id: Ie1f787cebb5f6da1a658f7dead879fa854901ef5
BUG: 1292254
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-on: http://review.gluster.org/12986
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
commit "4044e387dd40e2d12145fd32d5fd715406fcec8e" approach
to this led to deadlocks instead we rely on an old trick at
client side - without any need to modifying the volume globally.
Change-Id: I6e3c6bf9c0a3a0dd99a51b5d2a6c1f050ed2384c
BUG: 1091600
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/8007
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-by: Poornima G <pgurusid@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Users often forget to update the ping-timeout, perhaps
we should take care of this automatically
Change-Id: I6d14df8aa52665847233cb1760dfd54f41baadec
BUG: 1091600
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/7569
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Jose A. Rivera <jarrpa@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
|
| |
|
|
|
|
|
|
|
|
|
| |
Change-Id: I86ad5e9ed291866a8d478768fb447e269f51c39e
BUG: 1075182
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/7221
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Jose A. Rivera <jarrpa@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
|
|
|
Moved the hook-scripts to dirs corresponding to event.
Also, edited S30samba-set.sh to with changes in
other two hook scripts to bring uniformity.
Change-Id: Ib98c0a18d4bb5d0ba4b881b2e19b40d72580b1c2
BUG: 1073468
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/7201
Reviewed-by: Poornima G <pgurusid@redhat.com>
Reviewed-by: Bala FA <barumuga@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
|
