summaryrefslogtreecommitdiffstats
path: root/rfc.sh
Commit message (Collapse)AuthorAgeFilesLines
* scripts: Update rfc.sh to prompt for a github issue on RFE commitsShyam2017-04-191-0/+82
| | | | | | | | | | | | | | | | | | | | | | | If a commit does not contain a bug check with the committer if this is an RFE (or such) and prompt to amend the commit with a github issue that relates to the change. Also, give some specifics on what string to add to refer to an issue. This change is meant to encourage committers to add github issues and hence will not enforce the same, IOW the check can be ignored and code can still be submitted. Reviewers would hence be responsible to check for the same. Change-Id: Id382247a787a96d55be6be554332a1b7ccde6bcd BUG: 1428036 Signed-off-by: Shyam <srangana@redhat.com> Reviewed-on: https://review.gluster.org/17032 Smoke: Gluster Build System <jenkins@build.gluster.org> NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org> CentOS-regression: Gluster Build System <jenkins@build.gluster.org> Reviewed-by: Niels de Vos <ndevos@redhat.com>
* scripts: Update rfc.sh to check existance of Change-Id in backportsShyam2017-04-101-0/+70
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Addition to this script is a no-op on master. This would need to be backported to active release branches to be effective. This check is not smart proof, in that someone could proceed knowing that the Change-Id differs from master, but this is not expected to catch that, instead it is to serve more as a reminder that we need the same Change-Id across branches. Contributors not using rfc.sh would not see this, but they are few and possibly far in between. Also contributors using gerrit to cherry-pick changes will not see this. For both cases a server side solution to catch any changes are needed. There is a possiblilty that we will follow this up with a check on the gerrit end and add a comment to the reviews, to aid reviewers to quickly check the sanity of the Change-Id when it differs. Change-Id: I11e371489a4a3cf2ff96d9892256986cd535998b BUG: 1428047 Signed-off-by: Shyam <srangana@redhat.com> Reviewed-on: https://review.gluster.org/17004 Smoke: Gluster Build System <jenkins@build.gluster.org> Reviewed-by: Niels de Vos <ndevos@redhat.com> NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org> CentOS-regression: Gluster Build System <jenkins@build.gluster.org> Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com> Reviewed-by: Amar Tumballi <amarts@redhat.com>
* build: move checkpatch.pl to build-auxNiels de Vos2016-09-121-5/+5
| | | | | | | | | | | | | | There is no need for checkpatch.pl to be in extras/, it is used similar to other scripts that are placed in build-aux/. Change-Id: Id0f4db1666d83dad31687aa7aadae128fc14c016 BUG: 1198849 Signed-off-by: Niels de Vos <ndevos@redhat.com> Reviewed-on: http://review.gluster.org/15400 Smoke: Gluster Build System <jenkins@build.gluster.org> Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com> NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org> CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
* build: update link for .git/hooks/commit-msgKaleb S KEITHLEY2016-01-141-3/+3
| | | | | | | | Add -L option to curl cmd to follow a redirect Change-Id: I273248d2a610174cc3905b0ffb8f586deb191f5f Signed-off-by: Kaleb S KEITHLEY <kkeithle@redhat.com> Reviewed-on: http://review.gluster.org/13244
* Portability fix: rfc.shEmmanuel Dreyfus2016-01-121-1/+1
| | | | | | | | | | | | Function declaration in POSIX shell does not use the 'function' keyword. This is bash-specific. BUG: 1129939 Change-Id: Ifc2dddd0c0a99d2672aaa3aa1cdf18d0d1e38336 Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org> Reviewed-on: http://review.gluster.org/13206 Reviewed-by: Raghavendra Talur <rtalur@redhat.com> Tested-by: NetBSD Build System <jenkins@build.gluster.org>
* Make rfc.sh show what its actually doingPatrick Uiterwijk2015-12-031-0/+13
| | | | | | | | | | | Change-Id: Ifb9246a2680e5f985871d4209b46dd803979c2e1 BUG: 1131275 Signed-off-by: Patrick Uiterwijk <puiterwijk@redhat.com> Reviewed-on: http://review.gluster.org/8496 Reviewed-by: Niels de Vos <ndevos@redhat.com> Tested-by: Gluster Build System <jenkins@build.gluster.com> Tested-by: NetBSD Build System <jenkins@build.gluster.org> Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
* Fix incorrect rfc.sh and checkpatch.pl use of "jenkins" instead of "gerrit"Justin Clift2015-04-131-4/+6
| | | | | | | | | Change-Id: I6e78477554097a2be5aad8e3fb196970fb30dac2 Signed-off-by: Justin Clift <justin@gluster.org> Reviewed-on: http://review.gluster.org/10203 Tested-by: NetBSD Build System Reviewed-by: Niels de Vos <ndevos@redhat.com> Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
* extras/checkpatch.pl: linux kernel style patch verificationHarshavardhana2014-09-181-4/+43
| | | | | | | | | | | | | | | | | | | | | | | | | | This is to bring in adherence to coding policy, prior to patch submission for review. - no tabs - no whitespace - indentation (linux style) etc. This is in the interest at large for the GlusterFS codebase to be more cleaner and readable. ./rfc.sh - now supports running this for all patches diverged from "origin/master" revision. NOTE: One should take this as a handle for good guidelines and never use it as a tool for correctness, use common-sense in all the cases ;-) Change-Id: Ib9a5ed207cde152cb92b8d38cec83e8ce9ef7f28 BUG: 1120646 Signed-off-by: Harshavardhana <harsha@harshavardhana.net> Reviewed-on: http://review.gluster.org/8181 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Anders Blomdell <anders.blomdell@control.lth.se>
* rfc.sh: Include BUG: header even in first runAnand Avati2013-08-141-2/+2
| | | | | | | | | | Set the commit hook before entiring editor mode. This fixes the error where rfc.sh after first clone does not set BUG: header Change-Id: Ic0e9f2d3f656bc81e29d35556022fbdff2f61225 BUG: 764890 Signed-off-by: Anand Avati <avati@redhat.com> Reviewed-on: http://review.gluster.org/5632
* rfc.sh: set 'Change-Id: ' header on first runAnand Avati2012-08-151-0/+3
| | | | | | | | | | Let first run of rfc.sh include 'Change-Id:' as well Change-Id: I7b45a00d98f8c70ca3658c223a98f412f20cbb6f BUG: 764890 Signed-off-by: Anand Avati <avati@redhat.com> Reviewed-on: http://review.gluster.com/3785 Tested-by: Gluster Build System <jenkins@build.gluster.com>
* gerrit / rfc.sh: further trim of fetch targetCsaba Henk2012-04-231-1/+1
| | | | | | | | | | | | | | | We _really_ don't need anything to be fetched from anywhere except for origin. We can do away with all other tracked repos (which still can be a nuisance eg. if they are in a VPN that we are not happen to be joined to). Change-Id: I98b375698f999500153e5a000dc8dac5005dfaec BUG: 764966 Signed-off-by: Csaba Henk <csaba@redhat.com> Reviewed-on: http://review.gluster.com/3162 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Amar Tumballi <amarts@redhat.com> Reviewed-by: Anand Avati <avati@redhat.com>
* POSIXly correct: \n replacement is GNU sed specificEmmanuel Dreyfus2011-08-121-1/+1
| | | | | | | Change-Id: I5e4ca551b60477d454964e568209ad06f21cc64e Reviewed-on: http://review.gluster.com/227 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Anand Avati <avati@gluster.com>
* One more missing change :-/Emmanuel Dreyfus2011-08-121-1/+1
| | | | | | | Change-Id: I6eeaee73e7c9124a1959acb2fe47d5cad3a3baac Reviewed-on: http://review.gluster.com/225 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Anand Avati <avati@gluster.com>
* Use bourne shell, fix error in previous commitEmmanuel Dreyfus2011-08-121-8/+8
| | | | | | | Change-Id: Id2a304d5090eb2564c5d56ea260fa53b9b17d0d5 Reviewed-on: http://review.gluster.com/223 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Anand Avati <avati@gluster.com>
* sed -i is available from GNU sed, but is not portable. Output to a newEmmanuel Dreyfus2011-08-111-2/+3
| | | | | | | | | file and move it to the original one on success instead. Change-Id: Ib23dd9becd035054e6490dcb4d64b3f9eff89bf4 Reviewed-on: http://review.gluster.com/212 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Anand Avati <avati@gluster.com>
* gerrit: add a dry-run mode to rfc scriptCsaba Henk2011-07-231-2/+8
| | | | | | | | | | | | | With DRY_RUN=1, rfc.sh will not perform the git push just display the push command. This can be useful if one wants to give a final review for the submitted change list (check for typos, misplaced bug id-s) or if one is offline. Change-Id: I90e2016ba78e2a0ecf37044b3db0277a25914f77 BUG: 3234 Reviewed-on: http://review.gluster.com/87 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Anand Avati <avati@gluster.com>
* gerrit: some fixes for the rfc scriptCsaba Henk2011-07-231-2/+2
| | | | | | | | | | | | | | | | | | | | | In rebase_changes(): - Using "--all" for git fetch is bogus: the scope of this quantification is not over the tracked refs of the upsteam repo (which we do want, but that kind of universal quantification is already implied by the notion of "tracking"), but over the set of all the registered remotes, which is an annoying side effect. - $EDITOR is weaker than the git configuration settings. For the purpose of the script, we need to override any kind of setting, and that can be done via $GIT_EDITOR. Cf. git-fetch(1), git-commit(1). Change-Id: Ia91ee5c4d42dce9248f26f7697528e3c97355871 BUG: 3234 Reviewed-on: http://review.gluster.com/86 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Anand Avati <avati@gluster.com>
* s/Patchwork/Gerrit/Anand Avati2011-07-181-0/+104
Change-Id: I3d2e0c081cce5c69a6a168ddd0d850cdba84f53e
generated by cgit (git 2.34.1) at 2024-11-19 23:28:34 +0000