From 06c954a910fe8749b362490c62e5b49be5b0c385 Mon Sep 17 00:00:00 2001 From: Raghavendra Bhat Date: Thu, 31 Mar 2011 06:05:41 +0000 Subject: check dict before unrefing it Signed-off-by: Raghavendra Bhat Signed-off-by: Vijay Bellur BUG: 2642 ([glusterfs-3.2.0qa5]: invalid reads in glusterd) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2642 --- xlators/mgmt/glusterd/src/glusterd-handler.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xlators/mgmt/glusterd/src/glusterd-handler.c b/xlators/mgmt/glusterd/src/glusterd-handler.c index 386496ac733..f6b0ddf9a72 100644 --- a/xlators/mgmt/glusterd/src/glusterd-handler.c +++ b/xlators/mgmt/glusterd/src/glusterd-handler.c @@ -3038,7 +3038,7 @@ out: if (tmp_dict) dict_unref (tmp_dict); - if (ret) + if (ret && dict) dict_unref (dict); if (cli_req.dict_req.dict_req_val) free (cli_req.dict_req.dict_req_val); -- cgit