From 429d587114f1598774c1d3def064ea4f6415521b Mon Sep 17 00:00:00 2001 From: Oleksandr Natalenko Date: Tue, 9 Aug 2016 14:58:08 +0300 Subject: gfapi: use const qualifier for glfs_*timens() glfs_*timens() functions have the last argument of struct timespec type that is supposed to be const. Now using glfs_*timens() in fops, implemented on top of FUSE library, leads to compiler-time warning about discarding const qualifier. Introducing const qualifier does not break ABI, so let's just fix it. > Reviewed-on: http://review.gluster.org/15119 > Smoke: Gluster Build System > CentOS-regression: Gluster Build System > NetBSD-regression: NetBSD Build System > Reviewed-by: Niels de Vos BUG: 1365869 Change-Id: Iea2a1018de7dce67f67a8229671a5978246de800 Signed-off-by: Oleksandr Natalenko Reviewed-on: http://review.gluster.org/15137 Smoke: Gluster Build System NetBSD-regression: NetBSD Build System CentOS-regression: Gluster Build System Reviewed-by: Kaleb KEITHLEY Reviewed-by: Prashanth Pai --- api/src/glfs-fops.c | 8 +++++--- api/src/glfs.h | 6 +++--- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/api/src/glfs-fops.c b/api/src/glfs-fops.c index 66874de90d5..ff1702c6b4b 100644 --- a/api/src/glfs-fops.c +++ b/api/src/glfs-fops.c @@ -3085,7 +3085,8 @@ GFAPI_SYMVER_PUBLIC_DEFAULT(glfs_fchown, 3.4.0); int -pub_glfs_utimens (struct glfs *fs, const char *path, struct timespec times[2]) +pub_glfs_utimens (struct glfs *fs, const char *path, + const struct timespec times[2]) { int ret = -1; int valid = 0; @@ -3107,7 +3108,8 @@ GFAPI_SYMVER_PUBLIC_DEFAULT(glfs_utimens, 3.4.0); int -pub_glfs_lutimens (struct glfs *fs, const char *path, struct timespec times[2]) +pub_glfs_lutimens (struct glfs *fs, const char *path, + const struct timespec times[2]) { int ret = -1; int valid = 0; @@ -3129,7 +3131,7 @@ GFAPI_SYMVER_PUBLIC_DEFAULT(glfs_lutimens, 3.4.0); int -pub_glfs_futimens (struct glfs_fd *glfd, struct timespec times[2]) +pub_glfs_futimens (struct glfs_fd *glfd, const struct timespec times[2]) { int ret = -1; int valid = 0; diff --git a/api/src/glfs.h b/api/src/glfs.h index 6671b4a20d9..b53af35b158 100644 --- a/api/src/glfs.h +++ b/api/src/glfs.h @@ -675,14 +675,14 @@ int glfs_fchown (glfs_fd_t *fd, uid_t uid, gid_t gid) __THROW GFAPI_PUBLIC(glfs_fchown, 3.4.0); int glfs_utimens (glfs_t *fs, const char *path, - struct timespec times[2]) __THROW + const struct timespec times[2]) __THROW GFAPI_PUBLIC(glfs_utimens, 3.4.0); int glfs_lutimens (glfs_t *fs, const char *path, - struct timespec times[2]) __THROW + const struct timespec times[2]) __THROW GFAPI_PUBLIC(glfs_lutimens, 3.4.0); -int glfs_futimens (glfs_fd_t *fd, struct timespec times[2]) __THROW +int glfs_futimens (glfs_fd_t *fd, const struct timespec times[2]) __THROW GFAPI_PUBLIC(glfs_futimens, 3.4.0); ssize_t glfs_getxattr (glfs_t *fs, const char *path, const char *name, -- cgit