From 5a1644c892adeb370fdd6eb2adf0d49e0cf553b4 Mon Sep 17 00:00:00 2001 From: srijan-sivakumar Date: Mon, 21 Sep 2020 19:31:08 +0530 Subject: glusterd: Fixing coverity issues. Fixing Incorrect expression (IDENTICAL_BRANCHES) reported by the coverity scan. CID: 1432721 Change-Id: If6ab3a129dffb6c5fcc618e775f99bc1125003ab Updates: #1060 Signed-off-by: srijan-sivakumar --- xlators/mgmt/glusterd/src/glusterd-store.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/xlators/mgmt/glusterd/src/glusterd-store.c b/xlators/mgmt/glusterd/src/glusterd-store.c index e714fae41d3..af6a6be5d5c 100644 --- a/xlators/mgmt/glusterd/src/glusterd-store.c +++ b/xlators/mgmt/glusterd/src/glusterd-store.c @@ -3415,14 +3415,12 @@ glusterd_store_options(xlator_t *this, dict_t *opts) } ret = gf_store_rename_tmppath(shandle); - if (ret) { - goto out; - } out: shandle->fd = 0; GF_FREE(dict_data); - if ((ret < 0) && (fd > 0)) + if ((ret < 0) && (fd > 0)) { gf_store_unlink_tmppath(shandle); + } gf_store_handle_destroy(shandle); return ret; } -- cgit