From 5ab59ea0afab5309f6bf0371675fb4ecd66ae290 Mon Sep 17 00:00:00 2001 From: Sunil Kumar Acharya Date: Thu, 9 Feb 2017 16:34:54 +0530 Subject: cluster/ec: Change log level of messages to DEBUG Heal failed or passed should not be logged as info. These can be observed from heal info if the heal is happening or not. If we require to debug a case where heal is not happening, we can set the level to DEBUG. >Change-Id: I062668eadd145ef809b25e818e6bca1094f54cd6 >BUG: 1420619 >Signed-off-by: Sunil Kumar Acharya >Reviewed-on: https://review.gluster.org/16580 >Smoke: Gluster Build System >NetBSD-regression: NetBSD Build System >CentOS-regression: Gluster Build System >Reviewed-by: Ashish Pandey Change-Id: I91700a1960b5feb03ef186e4d0ddba1338152469 BUG: 1422783 Signed-off-by: Sunil Kumar Acharya Reviewed-on: https://review.gluster.org/16636 Smoke: Gluster Build System Reviewed-by: Xavier Hernandez NetBSD-regression: NetBSD Build System CentOS-regression: Gluster Build System --- xlators/cluster/ec/src/ec-heal.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/xlators/cluster/ec/src/ec-heal.c b/xlators/cluster/ec/src/ec-heal.c index 548649b9a35..06a4dbb5841 100644 --- a/xlators/cluster/ec/src/ec-heal.c +++ b/xlators/cluster/ec/src/ec-heal.c @@ -2334,6 +2334,7 @@ ec_heal_do (xlator_t *this, void *data, loc_t *loc, int32_t partial) gf_boolean_t blocking = _gf_false; gf_boolean_t need_heal = _gf_false; unsigned char *up_subvols = NULL; + char up_bricks[32]; ec = this->private; @@ -2372,15 +2373,16 @@ ec_heal_do (xlator_t *this, void *data, loc_t *loc, int32_t partial) ret = ec_heal_name (frame, ec, loc->parent, (char *)loc->name, participants); if (ret == 0) { - gf_msg (this->name, GF_LOG_INFO, 0, - EC_MSG_HEAL_SUCCESS, "%s: name heal " + gf_msg_debug (this->name, 0, "%s: name heal " "successful on %lX", loc->path, ec_char_array_to_mask (participants, ec->nodes)); } else { - gf_msg (this->name, GF_LOG_INFO, -ret, - EC_MSG_HEAL_FAIL, "%s: name heal " - "failed", loc->path); + gf_msg_debug (this->name, 0, "%s: name heal " + "failed. ret = %d, subvolumes up = %s", + loc->path, ret, + ec_bin(up_bricks, sizeof(up_bricks), ec->xl_up, + ec->nodes)); } } -- cgit