From 78a180afc67404f0937692290e1f54816136ad42 Mon Sep 17 00:00:00 2001 From: Milind Changire Date: Fri, 9 Mar 2018 16:17:38 +0530 Subject: rpcsvc: correct event-thread scaling Problem: Auto thread count derived from the number of attachs and detachs was reset to 1 when server_reconfigure() was called. Solution: Avoid auto-thread-count reset to 1. mainline: > BUG: 1547888 > Reviewed-on: https://review.gluster.org/19689 > Reviewed-by: Raghavendra G > Signed-off-by: Milind Changire (cherry picked from commit 0c3d984287d91d3fe1ffeef297252d912c08a410) Change-Id: Ic00e86adb81ba3c828e354a6ccb638209ae58b3e BUG: 1558959 Signed-off-by: Milind Changire --- xlators/protocol/server/src/server.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/xlators/protocol/server/src/server.c b/xlators/protocol/server/src/server.c index 6f1d2728847..1e491217c33 100644 --- a/xlators/protocol/server/src/server.c +++ b/xlators/protocol/server/src/server.c @@ -834,10 +834,11 @@ do_rpc: } /* - * Let the event subsystem know that we're auto-scaling, with an - * initial count of one. + * Update: + * We don't need to reset auto_thread_count since it has been derived + * out of the total bricks attached. We can reconfigure event threads + * but not auto threads. */ - ((struct event_pool *)(this->ctx->event_pool))->auto_thread_count = 1; GF_OPTION_RECONF ("event-threads", new_nthread, options, int32, out); ret = server_check_event_threads (this, conf, new_nthread); -- cgit