From 7c98143c7928f4ec936c90f0125b2a2aaf8f5174 Mon Sep 17 00:00:00 2001 From: Michael Scherer Date: Thu, 23 Feb 2017 22:57:42 +0100 Subject: mgmt: Fix null pointer deref since "this" can be NULL, we should skip this validation, there is another call to GF_VALIDATE_OR_GOTO in the following lines. Found by cppcheck. Change-Id: I329f50b986a9eaf3315e09f851080ab41bea57c0 BUG: 789278 Signed-off-by: Michael Scherer Reviewed-on: https://review.gluster.org/16742 Smoke: Gluster Build System Reviewed-by: Jeff Darcy Tested-by: Jeff Darcy NetBSD-regression: NetBSD Build System CentOS-regression: Gluster Build System --- xlators/mgmt/glusterd/src/glusterd-tierd-svc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/xlators/mgmt/glusterd/src/glusterd-tierd-svc.c b/xlators/mgmt/glusterd/src/glusterd-tierd-svc.c index 638d4941521..f58c6641f96 100644 --- a/xlators/mgmt/glusterd/src/glusterd-tierd-svc.c +++ b/xlators/mgmt/glusterd/src/glusterd-tierd-svc.c @@ -434,7 +434,6 @@ glusterd_tierdsvc_reconfigure (void *data) glusterd_volinfo_t *volinfo = NULL; volinfo = data; - GF_VALIDATE_OR_GOTO (this->name, data, out); /* reconfigure function is not available for other volume based * service. but it has been implemented for tier because there can be -- cgit