From 8668906b112a4053feecfea2072f7eb0a73a043c Mon Sep 17 00:00:00 2001 From: Aravinda VK Date: Fri, 9 Sep 2016 12:40:38 +0530 Subject: eventsapi: Add conditional import for requests library requests lib is used only during publishing event. gf_event python imports utils.py, and indirectly imports requests lib even though it is not required while sending event to eventsd. Moved "import requests" inside the "plugin_webhook" function. > Reviewed-on: http://review.gluster.org/15439 > Reviewed-by: Prashanth Pai > Smoke: Gluster Build System > NetBSD-regression: NetBSD Build System > Reviewed-by: Kotresh HR > CentOS-regression: Gluster Build System BUG: 1375537 Change-Id: Ie3c8088b43d4d7952d01352731999bf8519c73c4 Signed-off-by: Aravinda VK (cherry picked from commit aa742fd88e08eeb807dba1cb98402e8813ec6797) Reviewed-on: http://review.gluster.org/15487 Smoke: Gluster Build System CentOS-regression: Gluster Build System NetBSD-regression: NetBSD Build System Reviewed-by: Atin Mukherjee --- events/src/utils.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/events/src/utils.py b/events/src/utils.py index db8ebfe29a9..dadd9ae3332 100644 --- a/events/src/utils.py +++ b/events/src/utils.py @@ -15,7 +15,6 @@ import logging import fcntl from errno import ESRCH, EBADF -import requests from eventsapiconf import (LOG_FILE, WEBHOOKS_FILE, DEFAULT_CONFIG_FILE, @@ -145,6 +144,9 @@ def publish(ts, event_key, data): def plugin_webhook(message): + # Import requests here since not used in any other place + import requests + message_json = json.dumps(message, sort_keys=True) logger.debug("EVENT: {0}".format(message_json)) for url, token in _webhooks.items(): -- cgit