From 90d691d049420f712f5bd1898c75cc66edd1b315 Mon Sep 17 00:00:00 2001 From: M S Vishwanath Bhat Date: Fri, 14 Oct 2011 17:29:41 +0530 Subject: makes 'volume top' exit with exit status '0' upon success volume top exit status was not zero even when command was successful Change-Id: I12761cb6f00ad5c851bfee7cf0aaf0b92dfb94f4 BUG: 2882 testcase: run any valid 'volume top' command and check for exit status Reviewed-on: http://review.gluster.com/587 Tested-by: Gluster Build System Reviewed-by: Vijay Bellur --- cli/src/cli-rpc-ops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cli/src/cli-rpc-ops.c b/cli/src/cli-rpc-ops.c index 761c67cbbb5..29589591ea6 100644 --- a/cli/src/cli-rpc-ops.c +++ b/cli/src/cli-rpc-ops.c @@ -3238,7 +3238,7 @@ gf_cli3_1_top_volume_cbk (struct rpc_req *req, struct iovec *iov, ret = dict_get_int32 (dict, key, (int32_t*)&top_op); if (ret) goto out; - while (i <= brick_count) { + while (i < brick_count) { i++; snprintf (brick, sizeof (brick), "%d-brick", i); ret = dict_get_str (dict, brick, &bricks); -- cgit