From aaa5b2ec2f0ef1a62047c9ab91d957c7b0a1552a Mon Sep 17 00:00:00 2001 From: Michael Scherer Date: Wed, 22 Feb 2017 17:09:46 +0100 Subject: Fix bad free Since rsp.path is assigned a constant string, free would operate on a incorrect pointer, with likely bad results. Found by coverity scan Change-Id: I4befdd78573daa3c0c3013100f7ae69a2dcae36a BUG: 789278 Signed-off-by: Michael Scherer Reviewed-on: https://review.gluster.org/16716 Smoke: Gluster Build System Tested-by: N Balachandran Reviewed-by: N Balachandran NetBSD-regression: NetBSD Build System CentOS-regression: Gluster Build System Reviewed-by: Jeff Darcy --- xlators/mgmt/glusterd/src/glusterd-handler.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/xlators/mgmt/glusterd/src/glusterd-handler.c b/xlators/mgmt/glusterd/src/glusterd-handler.c index 40f5704b698..2a497974d77 100644 --- a/xlators/mgmt/glusterd/src/glusterd-handler.c +++ b/xlators/mgmt/glusterd/src/glusterd-handler.c @@ -3204,7 +3204,7 @@ __glusterd_handle_mount (rpcsvc_request_t *req) out: if (!rsp.path) - rsp.path = ""; + rsp.path = gf_strdup(""); glusterd_submit_reply (req, &rsp, NULL, 0, NULL, (xdrproc_t)xdr_gf1_cli_mount_rsp); @@ -3212,8 +3212,8 @@ __glusterd_handle_mount (rpcsvc_request_t *req) if (dict) dict_unref (dict); - if (*rsp.path) - GF_FREE (rsp.path); + + GF_FREE (rsp.path); glusterd_friend_sm (); glusterd_op_sm (); -- cgit