From af0eb165f624c6a76e84e5a0c78881715ceae7c3 Mon Sep 17 00:00:00 2001 From: Raghavendra G Date: Tue, 27 Mar 2012 08:47:35 +0530 Subject: performance/write-behind: queue setattr fop with writes always. stat returned in setattr_cbk can be cached by the kernel. Hence it is always necessary that we return correct stat, which implies that setattr should not be out of order with respect to write fops. Change-Id: I305feeb4802f8a41ffaf032100832cbd65dfc5c1 BUG: 765443 Signed-off-by: Raghavendra G Reviewed-on: http://review.gluster.com/3011 Tested-by: Gluster Build System Reviewed-by: Amar Tumballi Reviewed-by: Vijay Bellur --- xlators/performance/write-behind/src/write-behind.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/xlators/performance/write-behind/src/write-behind.c b/xlators/performance/write-behind/src/write-behind.c index d1b9f6feb37..9bb3673fcd7 100644 --- a/xlators/performance/write-behind/src/write-behind.c +++ b/xlators/performance/write-behind/src/write-behind.c @@ -1283,13 +1283,6 @@ wb_setattr (call_frame_t *frame, xlator_t *this, loc_t *loc, frame->local = local; - if (!(valid & (GF_SET_ATTR_ATIME | GF_SET_ATTR_MTIME))) { - STACK_WIND (frame, wb_setattr_cbk, FIRST_CHILD (this), - FIRST_CHILD (this)->fops->setattr, loc, stbuf, - valid, xdata); - goto out; - } - if (loc->inode) { /* FIXME: fd_lookup extends life of fd till the execution @@ -1340,7 +1333,7 @@ unwind: if (stub) { call_stub_destroy (stub); } -out: + return 0; } -- cgit