From b14f26a869c056fb9951e481ae20f3887edb743d Mon Sep 17 00:00:00 2001 From: Samikshan Bairagya Date: Mon, 17 Jul 2017 17:38:48 +0530 Subject: glusterd: Add description field to global options for brick-mux Currently the "cluster.brick-multiplex" and "cluster.max-bricks-per-process" options do not show anything in the description field when gluster volume set help is called. This commit adds the description fields for these 2 options. Change-Id: I3d162c61fa2774dd994f046e305d457f0fd43192 BUG: 1471790 Signed-off-by: Samikshan Bairagya Reviewed-on: https://review.gluster.org/17790 Reviewed-by: Atin Mukherjee Smoke: Gluster Build System Reviewed-by: Gaurav Yadav CentOS-regression: Gluster Build System --- xlators/mgmt/glusterd/src/glusterd-volume-set.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/xlators/mgmt/glusterd/src/glusterd-volume-set.c b/xlators/mgmt/glusterd/src/glusterd-volume-set.c index 906fec07018..5ef86f764f4 100644 --- a/xlators/mgmt/glusterd/src/glusterd-volume-set.c +++ b/xlators/mgmt/glusterd/src/glusterd-volume-set.c @@ -3443,13 +3443,23 @@ struct volopt_map_entry glusterd_volopt_map[] = { .voltype = "mgmt/glusterd", .value = "off", .op_version = GD_OP_VERSION_3_10_0, - .validate_fn = validate_boolean + .validate_fn = validate_boolean, + .type = GLOBAL_DOC, + .description = "This global option can be used to enable/disable " + "brick multiplexing. Brick multiplexing ensures that " + "compatible brick instances can share one single " + "brick process." }, { .key = GLUSTERD_BRICKMUX_LIMIT_KEY, .voltype = "mgmt/glusterd", .value = "1", .op_version = GD_OP_VERSION_3_12_0, - .validate_fn = validate_mux_limit + .validate_fn = validate_mux_limit, + .type = GLOBAL_DOC, + .description = "This option can be used to limit the number of brick " + "instances per brick process when brick multiplexing " + "is enabled. This option can be set only when brick " + "multiplexing feature enabled." }, { .key = "disperse.optimistic-change-log", .voltype = "cluster/disperse", -- cgit