From d0f62e8b4fc605c522f7971a82cbbf027e06960e Mon Sep 17 00:00:00 2001 From: vmallika Date: Thu, 19 Mar 2015 07:02:24 +0530 Subject: posix: handle failure from posix_resolve This is backport of http://review.gluster.org/#/c/9941/ > When building ancestory, posix_resolve gets the inode > from the gfid. We need to handle the failure case from > this function > > Change-Id: I19f0f0c739686b1b0ef96309212aa1c7911b3589 > BUG: 1203629 > Signed-off-by: vmallika > Reviewed-on: http://review.gluster.org/9941 > Reviewed-by: Raghavendra Bhat > Tested-by: Gluster Build System > Reviewed-by: Pranith Kumar Karampuri > Tested-by: Pranith Kumar Karampuri Change-Id: I9933b653e6bdf9fbfd1f65081622f47ed7f25e45 BUG: 1217419 Signed-off-by: vmallika Reviewed-on: http://review.gluster.org/10469 Tested-by: Gluster Build System Reviewed-by: Raghavendra Bhat --- xlators/storage/posix/src/posix-handle.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/xlators/storage/posix/src/posix-handle.c b/xlators/storage/posix/src/posix-handle.c index ab202d79dc9..19f27b3c284 100644 --- a/xlators/storage/posix/src/posix-handle.c +++ b/xlators/storage/posix/src/posix-handle.c @@ -176,6 +176,10 @@ posix_make_ancestryfromgfid (xlator_t *this, char *path, int pathsize, memset (&iabuf, 0, sizeof (iabuf)); inode = posix_resolve (this, itable, *parent, dir_name, &iabuf); + if (inode == NULL) { + ret = -1; + goto out; + } strcat (dir_name, "/"); ret = posix_make_ancestral_node (priv_base_path, path, pathsize, head, -- cgit