From e8847bd0ba03616bf80f242fda22e104ff2ea0e3 Mon Sep 17 00:00:00 2001 From: Ashish Pandey Date: Wed, 17 Jun 2015 12:40:06 +0530 Subject: ec: Display correct message after successful heal start Problem : While launching heal, it shows heal launch was unsuccessful. However, internaly it was successfully launched. Solution : Don't reset op_ret to -1 in for loop for every brick. Change-Id: Iff89fdaf6082767ed67523a56430a9e83e6984d3 BUG: 1203089 Signed-off-by: Ashish Pandey Reviewed-on: http://review.gluster.org/11267 Reviewed-by: Xavier Hernandez Tested-by: NetBSD Build System --- xlators/cluster/ec/src/ec-heald.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xlators/cluster/ec/src/ec-heald.c b/xlators/cluster/ec/src/ec-heald.c index a7cf8f7bd30..bfdf9597e0e 100644 --- a/xlators/cluster/ec/src/ec-heald.c +++ b/xlators/cluster/ec/src/ec-heald.c @@ -541,10 +541,10 @@ ec_heal_op (xlator_t *this, dict_t *output, gf_xl_afr_op_t op, int xl_id) ec = this->private; + op_ret = -1; for (i = 0; i < ec->nodes; i++) { snprintf (key, sizeof (key), "%d-%d-status", xl_id, i); - op_ret = -1; if (((ec->xl_up >> i) & 1) == 0) { ret = dict_set_str (output, key, "Brick is not connected"); } else if (!ec->up) { -- cgit