From 2e1e685b4f36b7e532b297184270845ae41683ff Mon Sep 17 00:00:00 2001 From: Niels de Vos Date: Thu, 27 Jul 2017 09:54:15 +0200 Subject: gfapi: mark glfs_ipc() for internal use only The 3.7 version of glfs_ipc() has never been used by external applications. There is little use for internal xlator communication that is triggered from outside of core GlusterFS executables. This function has now been removed from libgfapi.so. For Gluster 4.0 a new variation for glfs_ipc() has been added. The function expects dict_t parameters, which are currently not available for external applications. There is no sense in providing glfs_ipc() for non-core GlusterFS executables. Therefore, glfs_ipc() has been marked as private, and the declaration is now in the glfs-internal.h header. The Python test case (tests/features/ipctest.py) is not correct and will be re-written in C to prevent portability issues. This test is currently disabled (commit d26f0bac149d495fa93710c3f7b6b63c36cb8387). Cherry picked from commit 40d71d6a201d618e52555a062ac1a429d36ca9ca: > Change-Id: Idbfe35570d34d45ce8b6b43084627a552ac21f59 > Fixes: #269 > Signed-off-by: Niels de Vos > Reviewed-on: https://review.gluster.org/17854 > Smoke: Gluster Build System > CentOS-regression: Gluster Build System > Reviewed-by: soumya k > Reviewed-by: Kaleb KEITHLEY Change-Id: Idbfe35570d34d45ce8b6b43084627a552ac21f59 Fixes: #269 Signed-off-by: Niels de Vos Reviewed-on: https://review.gluster.org/17894 Smoke: Gluster Build System CentOS-regression: Gluster Build System Reviewed-by: Kaleb KEITHLEY Reviewed-by: jiffin tony Thottan --- api/src/glfs-internal.h | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'api/src/glfs-internal.h') diff --git a/api/src/glfs-internal.h b/api/src/glfs-internal.h index b5d3f78bf7c..838b5c748b2 100644 --- a/api/src/glfs-internal.h +++ b/api/src/glfs-internal.h @@ -490,4 +490,10 @@ glfd_entry_next (struct glfs_fd *glfd, int plus); void gf_dirent_to_dirent (gf_dirent_t *gf_dirent, struct dirent *dirent); +/* + * Nobody needs this call at all yet except for the test script. + */ +int glfs_ipc (glfs_fd_t *fd, int cmd, void *xd_in, void **xd_out) __THROW + GFAPI_PRIVATE(glfs_ipc, 3.12.0); + #endif /* !_GLFS_INTERNAL_H */ -- cgit