From e740b700975bdb1014ede99c65731095bdf81a72 Mon Sep 17 00:00:00 2001 From: Kaleb S KEITHLEY Date: Mon, 13 Jun 2016 11:34:51 -0400 Subject: api: use versioned symbols for minor ABI change No need to expand the API/ABI. E.g., see how glfs_lookupat changed between 3.7.0 and 3.7.4 IIRC (I originally argued against versioning the library. I wanted to just add new functions as they were needed, as was initially done for glfs_ipc and glfs_ipc_xd in the master branch for 4.0. But others strongly wanted versioning.) Having made the decision to use versioning, I believe we should continue. At least until we have a public decision that we're no longer going to use versioning. Change-Id: I0c3b2c1cbb297ae2b2864b647c224922987d74ad Signed-off-by: Kaleb S KEITHLEY Reviewed-on: http://review.gluster.org/14717 Reviewed-by: Shyamsundar Ranganathan Smoke: Gluster Build System NetBSD-regression: NetBSD Build System CentOS-regression: Gluster Build System Reviewed-by: Jeff Darcy --- api/src/glfs.h | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) (limited to 'api/src/glfs.h') diff --git a/api/src/glfs.h b/api/src/glfs.h index d3bf1b4cdcc..bf6dd6cd566 100644 --- a/api/src/glfs.h +++ b/api/src/glfs.h @@ -72,7 +72,6 @@ __BEGIN_DECLS struct glfs; typedef struct glfs glfs_t; - /* SYNOPSIS @@ -770,12 +769,10 @@ glfs_fd_t *glfs_dup (glfs_fd_t *fd) __THROW GFAPI_PUBLIC(glfs_dup, 3.4.0); /* - * No xdata support for now. Nobody needs this call at all yet except for the - * test script, and that doesn't need xdata. Adding dict_t support and a new - * header-file requirement doesn't seem worth it until the need is greater. + * Nobody needs this call at all yet except for the test script. */ -int glfs_ipc (glfs_fd_t *fd, int cmd) __THROW - GFAPI_PUBLIC(glfs_ipc, 3.7.0); +int glfs_ipc (glfs_fd_t *fd, int cmd, void *xd_in, void **xd_out) __THROW + GFAPI_PUBLIC(glfs_ipc, 4.0.0); __END_DECLS -- cgit