From 56ed983c2d4cbfaffefb404e21db766007629400 Mon Sep 17 00:00:00 2001 From: Soumya Koduri Date: Fri, 22 Jul 2016 13:15:58 +0530 Subject: gfapi/upcall: Fix a ref leak inode_find (used to create the handle) takes a reference of the inode. This needs to be un'refernced to avoid leak. This is backport of below master patch - http://review.gluster.org/14984 >Change-Id: I22f03577a8f1d9608cfc62d57202cfc4c2ba12b3 >BUG: 1358608 >Signed-off-by: Soumya Koduri >Reviewed-on: http://review.gluster.org/14984 >Reviewed-by: jiffin tony Thottan >Reviewed-by: Jeff Darcy >(cherry picked from commit bb48eb46910085928efbd7fb491c5b2db25bba98) Change-Id: I92701af8a948d982fd4dbe31af32334c1bb26347 BUG: 1361665 Signed-off-by: Soumya Koduri Reviewed-on: http://review.gluster.org/15049 NetBSD-regression: NetBSD Build System CentOS-regression: Gluster Build System Reviewed-by: Niels de Vos Smoke: Gluster Build System --- api/src/glfs-handleops.c | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'api') diff --git a/api/src/glfs-handleops.c b/api/src/glfs-handleops.c index 1c5546ec427..2b436f9bc4d 100644 --- a/api/src/glfs-handleops.c +++ b/api/src/glfs-handleops.c @@ -1843,6 +1843,10 @@ glfs_h_find_handle (struct glfs *fs, unsigned char *handle, int len) gf_uuid_copy (object->gfid, object->inode->gfid); out: + /* inode_find takes a reference. Unref it. */ + if (newinode) + inode_unref (newinode); + glfs_subvol_done (fs, subvol); __GLFS_EXIT_FS; -- cgit