From 1ae8b4c33af175545d6afe99aeb7a21896960a35 Mon Sep 17 00:00:00 2001 From: Mohammed Rafi KC Date: Thu, 5 Feb 2015 16:12:53 +0530 Subject: snapshot: append timestamp with snapname Appending GMT time stamp with snapname by default. If no-timestamp flag is given during snapshot creation, then time stamp will not append with snapname; Initial consumer of this feature is Samba's Shadow Copy feature. This feature allows Windows user to get previous revisions of a file. For this feature to work snapshot names under .snaps folder (USS) should have timestamp in following format appended: @GMT-YYYY.MM.DD-hh.mm.ss PS: https://www.samba.org/samba/docs/man/manpages/vfs_shadow_copy2.8.html This format is configurable by Samba conf file. Due to a limitation in Windows directory access the exact format cannot be used by USS. Therefore we have modified the file format to: _GMT-YYYY.MM.DD-hh.mm.ss Snapshot scheduling feature also required to append timestamp to the snapshot name therefore timestamp is appended in snapshot creation itself instead of doing the changes in snapview server. More info: https://www.mail-archive.com/gluster-users@gluster.org/msg18895.html Change-Id: Idac24670948cf4c0fbe916ea6690e49cbc832d07 BUG: 1189473 Signed-off-by: Mohammed Rafi KC Reviewed-on: http://review.gluster.org/9597 Tested-by: Gluster Build System Reviewed-by: Rajesh Joseph Reviewed-by: Krishnan Parthasarathi Tested-by: Krishnan Parthasarathi --- cli/src/cli-cmd-snapshot.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'cli/src/cli-cmd-snapshot.c') diff --git a/cli/src/cli-cmd-snapshot.c b/cli/src/cli-cmd-snapshot.c index d03b5b99dd0..7c6a52e0a88 100644 --- a/cli/src/cli-cmd-snapshot.c +++ b/cli/src/cli-cmd-snapshot.c @@ -82,7 +82,8 @@ struct cli_cmd snapshot_cmds[] = { cli_cmd_snapshot_help_cbk, "display help for snapshot commands" }, - { "snapshot create [description ] [force]", + { "snapshot create [no-timestamp] " + "[description ] [force]", cli_cmd_snapshot_cbk, "Snapshot Create." }, -- cgit