From 83304fedb464fe3f97db662ce3e07bd948b7b7d9 Mon Sep 17 00:00:00 2001 From: Amar Tumballi Date: Tue, 6 Nov 2018 22:47:41 +0530 Subject: all: fix the format string exceptions Currently, there are possibilities in few places, where a user-controlled (like filename, program parameter etc) string can be passed as 'fmt' for printf(), which can lead to segfault, if the user's string contains '%s', '%d' in it. While fixing it, makes sense to make the explicit check for such issues across the codebase, by making the format call properly. Fixes: CVE-2018-14661 Fixes: bz#1647666 Change-Id: Ib547293f2d9eb618594cbff0df3b9c800e88bde4 Signed-off-by: Amar Tumballi --- cli/src/cli-cmd-volume.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'cli/src') diff --git a/cli/src/cli-cmd-volume.c b/cli/src/cli-cmd-volume.c index ab17729d182..ad0d80d87db 100644 --- a/cli/src/cli-cmd-volume.c +++ b/cli/src/cli-cmd-volume.c @@ -2837,7 +2837,7 @@ cli_launch_glfs_heal(int heal_op, dict_t *options) runner_add_args(&runner, "source-brick", NULL); runner_argprintf(&runner, "%s:%s", hostname, path); if (dict_get_str(options, "file", &filename) == 0) - runner_argprintf(&runner, filename); + runner_argprintf(&runner, "%s", filename); break; case GF_SHD_OP_SPLIT_BRAIN_FILES: runner_add_args(&runner, "split-brain-info", NULL); -- cgit