From 33131131469e18d3ebbdc6ce741c2984dc77b290 Mon Sep 17 00:00:00 2001 From: Anoop C S Date: Wed, 21 Mar 2018 13:09:01 +0530 Subject: extras/hooks: Do not blindly remove volume share from smb.conf When Gluster volumes are shared via Samba, any extra smb.conf parameter setting done by administrator to those shares are lost during restart of the volume. Instead of removing the whole share completely from smb.conf(via hook scripts during volume stop) it is better to make it temporarily unavailable to end-users till the volume is started again. Therefore we make use of a smb.conf parameter named 'available'[1] to achieve the above intend. [1] https://www.samba.org/samba/docs/current/man-html/smb.conf.5.html Change-Id: I68a9055b50791f6ffd3b95a3c13d858a75fa6530 fixes: bz#1558921 BUG: 1558921 Signed-off-by: Anoop C S --- extras/hook-scripts/start/post/S30samba-start.sh | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'extras/hook-scripts/start/post') diff --git a/extras/hook-scripts/start/post/S30samba-start.sh b/extras/hook-scripts/start/post/S30samba-start.sh index 92ddaf4e37f..5d586ee9fae 100755 --- a/extras/hook-scripts/start/post/S30samba-start.sh +++ b/extras/hook-scripts/start/post/S30samba-start.sh @@ -127,5 +127,7 @@ find_config_info if ! grep --quiet "\[gluster-$VOL\]" ${CONFIGFILE} ; then add_samba_share $VOL - sighup_samba +else + sed -i '/\[gluster-'"$VOL"'\]/,/^$/!b;/available = no/d' ${CONFIGFILE} fi +sighup_samba -- cgit