From 0bd9beabd2facbd2c7fb52e74dc56ecb89abde8e Mon Sep 17 00:00:00 2001 From: Paul Stauffer Date: Mon, 17 Aug 2015 21:00:11 -0700 Subject: bash-completion: Swap order of characters in egrep bracket expression With glusterfs-cli installed, bash tab completion fails to work and prints an error message: $ gluster volgrep: Invalid range end ^C The problem is caused by the ordering of characters within an egrep bracket expression in the "_gluster_completion()" function defined in /etc/bash_completion.d/gluster. The file contains this line: egrep -ao --color=never "([A-Za-z0-9_-.]+)|[[:space:]]+|." | \ And egrep is interpreting the "-" character in that bracket expression as indicating a range is being requested, "_-." Fortunately, "_" actually comes after ".", this range expression is invalid, and egrep throws the error instead of silently not doing what was intended. The fix is simply to swap the positions of "-" and "." in that bracket expression: egrep -ao --color=never "([A-Za-z0-9_.-]+)|[[:space:]]+|." | \ With this change, bash tab completion works as intended. Change-Id: Iace2d57a1122b4530987ba6f5f5558b56b094665 BUG: 1243108 Signed-off-by: Paul Stauffer Reviewed-on: http://review.gluster.org/11939 Tested-by: Gluster Build System Reviewed-by: Niels de Vos Reviewed-by: Vijay Bellur --- extras/command-completion/gluster.bash | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'extras') diff --git a/extras/command-completion/gluster.bash b/extras/command-completion/gluster.bash index be0591c7211..680ecd964d5 100644 --- a/extras/command-completion/gluster.bash +++ b/extras/command-completion/gluster.bash @@ -480,7 +480,7 @@ _gluster_handle_list () _gluster_completion () { FINAL_LIST=`echo $GLUSTER_COMMAND_TREE | \ - egrep -ao --color=never "([A-Za-z0-9_-.]+)|[[:space:]]+|." | \ + egrep -ao --color=never "([A-Za-z0-9_.-]+)|[[:space:]]+|." | \ egrep -v --color=never "^[[:space:]]*$" | \ _gluster_parse` -- cgit