From 65aed1070cc2e44959cf3a0fbfde635de7e03103 Mon Sep 17 00:00:00 2001 From: Kotresh HR Date: Mon, 24 Sep 2018 21:18:30 +0530 Subject: georep: python3 compatibility (Popen) The file objects for python3 by default is opened in binary mode where as in python2 it's opened as text by default. The geo-rep code parses the output of Popen assuming it as text, hence used the 'universal_newlines' flag which provides backward compatibility for the same. Change-Id: I371a03b6348af9666164cb2e8b93d47475431ad9 Updates: #411 Signed-off-by: Kotresh HR --- geo-replication/syncdaemon/subcmds.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'geo-replication/syncdaemon/subcmds.py') diff --git a/geo-replication/syncdaemon/subcmds.py b/geo-replication/syncdaemon/subcmds.py index 11d263d7e03..30050ec4743 100644 --- a/geo-replication/syncdaemon/subcmds.py +++ b/geo-replication/syncdaemon/subcmds.py @@ -112,7 +112,8 @@ def subcmd_voluuidget(args): po = Popen(['gluster', '--xml', '--remote-host=' + args.host, 'volume', 'info', args.volname], bufsize=0, - stdin=None, stdout=PIPE, stderr=PIPE) + stdin=None, stdout=PIPE, stderr=PIPE, + universal_newlines=True) vix, err = po.communicate() if po.returncode != 0: -- cgit