From 0be8e038d9bf90be94f3e3a7d6ea5bee88da9ecb Mon Sep 17 00:00:00 2001 From: Jeff Darcy Date: Thu, 29 Jun 2017 06:50:56 -0700 Subject: multiple: fix struct/typedef inconsistencies The most common pattern, both in our code and elsewhere, is this: struct _xyz { ... }; typedef struct _xyz xyz_t; These exceptions - especially call_frame/call_stack - have been slowing down code navigation for years. By converging on a single pattern, navigating from xyz_t in code to the actual definition of struct _xyz (i.e. without having to visit the typedef first) might even be automatable. Change-Id: I0e5dd1f51f98e000173c62ef4ddc5b21d9ec44ed Signed-off-by: Jeff Darcy Reviewed-on: https://review.gluster.org/17650 Smoke: Gluster Build System Tested-by: Jeff Darcy CentOS-regression: Gluster Build System Reviewed-by: Amar Tumballi Reviewed-by: Niels de Vos --- libglusterfs/src/client_t.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'libglusterfs/src/client_t.h') diff --git a/libglusterfs/src/client_t.h b/libglusterfs/src/client_t.h index b4546f36bea..7666f0132b6 100644 --- a/libglusterfs/src/client_t.h +++ b/libglusterfs/src/client_t.h @@ -20,7 +20,7 @@ struct client_ctx { void *ctx_value; }; -typedef struct _client_t { +typedef struct _client { struct { /* e.g. protocol/server stashes its ctx here */ gf_lock_t lock; -- cgit