From d5409aae63a7ac5e5b3ea6cfa16c6250a028291c Mon Sep 17 00:00:00 2001
From: Sakshi <sabansal@redhat.com>
Date: Wed, 15 Apr 2015 13:28:24 +0530
Subject: libglusterfs: coverity fix

fix missing varargs cleanup

CID 1124856: string overflow

CID 1124656: NULL return

CID 1124374: constant expression

Change-Id: Iead530c599bdfef05a40c68b892215f4e4f02247
BUG: 789278
Signed-off-by: Sakshi Bansal <sabansal@redhat.com>
Reviewed-on: http://review.gluster.org/9630
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
---
 libglusterfs/src/logging.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

(limited to 'libglusterfs/src/logging.c')

diff --git a/libglusterfs/src/logging.c b/libglusterfs/src/logging.c
index c233aedc359..4408c5f674c 100644
--- a/libglusterfs/src/logging.c
+++ b/libglusterfs/src/logging.c
@@ -914,6 +914,8 @@ out:
 
         FREE (str2);
 
+        va_end (ap);
+
         return ret;
 }
 
@@ -2269,6 +2271,7 @@ err:
         FREE (str2);
 
 out:
+        va_end (ap);
         return (0);
 }
 
@@ -2318,7 +2321,9 @@ out:
         if (str2)
                 FREE (str2);
 
-         return ret;
+        va_end (ap);
+
+        return ret;
 }
 
 int
@@ -2470,5 +2475,7 @@ out:
 
         FREE (str2);
 
+        va_end (ap);
+
         return ret;
 }
-- 
cgit