From 83304fedb464fe3f97db662ce3e07bd948b7b7d9 Mon Sep 17 00:00:00 2001 From: Amar Tumballi Date: Tue, 6 Nov 2018 22:47:41 +0530 Subject: all: fix the format string exceptions Currently, there are possibilities in few places, where a user-controlled (like filename, program parameter etc) string can be passed as 'fmt' for printf(), which can lead to segfault, if the user's string contains '%s', '%d' in it. While fixing it, makes sense to make the explicit check for such issues across the codebase, by making the format call properly. Fixes: CVE-2018-14661 Fixes: bz#1647666 Change-Id: Ib547293f2d9eb618594cbff0df3b9c800e88bde4 Signed-off-by: Amar Tumballi --- libglusterfs/src/statedump.h | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'libglusterfs/src/statedump.h') diff --git a/libglusterfs/src/statedump.h b/libglusterfs/src/statedump.h index 6c32c161ad3..af653041493 100644 --- a/libglusterfs/src/statedump.h +++ b/libglusterfs/src/statedump.h @@ -81,10 +81,12 @@ void gf_proc_dump_info(int signum, glusterfs_ctx_t *ctx); int -gf_proc_dump_add_section(char *key, ...); +gf_proc_dump_add_section(char *key, ...) + __attribute__((__format__(__printf__, 1, 2))); int -gf_proc_dump_write(char *key, char *value, ...); +gf_proc_dump_write(char *key, char *value, ...) + __attribute__((__format__(__printf__, 2, 3))); void inode_table_dump(inode_table_t *itable, char *prefix); -- cgit