From 44602465081ea5fb38255ad68d3ed8e987190d1f Mon Sep 17 00:00:00 2001 From: Yaniv Kaul Date: Sun, 12 Jan 2020 16:33:54 +0200 Subject: dictionary: remove the 'extra_free' parameter This parameter may have been used in the past, but is no longer needed. Removing it and the few locations it was actually referenced. This allows to remove an extra memdup as well, that was not needed in the 1st place in server_setvolume() and unserialize_rsp_direntp() functions. A followup separate patch will remove extra_stdfree parmeter from the dictionary structure. Change-Id: Ica0ff0a330672373aaa60e808b7e76ec489a0fe3 updates: bz#1193929 Signed-off-by: Yaniv Kaul --- libglusterfs/src/dict.c | 1 - libglusterfs/src/glusterfs/dict.h | 1 - 2 files changed, 2 deletions(-) (limited to 'libglusterfs') diff --git a/libglusterfs/src/dict.c b/libglusterfs/src/dict.c index 2682e6afe05..ddd27ebd940 100644 --- a/libglusterfs/src/dict.c +++ b/libglusterfs/src/dict.c @@ -705,7 +705,6 @@ dict_destroy(dict_t *this) mem_put(this->members); } - GF_FREE(this->extra_free); free(this->extra_stdfree); /* update 'ctx->stats.dict.details' using max_count */ diff --git a/libglusterfs/src/glusterfs/dict.h b/libglusterfs/src/glusterfs/dict.h index 8fc4b7ebbd9..ce1c2100276 100644 --- a/libglusterfs/src/glusterfs/dict.h +++ b/libglusterfs/src/glusterfs/dict.h @@ -118,7 +118,6 @@ struct _dict { gf_atomic_t refcount; data_pair_t **members; data_pair_t *members_list; - char *extra_free; char *extra_stdfree; gf_lock_t lock; data_pair_t *members_internal; -- cgit