From 688abcc90745515f7e143ef8cf1e938239db597c Mon Sep 17 00:00:00 2001 From: Nigel Babu Date: Mon, 20 Feb 2017 08:27:51 +0530 Subject: libglusterfs, gfdb, glusterfs: Add missing breaks A few switches did not have breaks causing fall throughs. Most of them have been fixed with fall through comments for those that are intentional. Change-Id: I84c85726b542f38504b50fefab5eba5dbcd27a07 BUG: 1424894 Signed-off-by: Nigel Babu Reviewed-on: https://review.gluster.org/16677 NetBSD-regression: NetBSD Build System CentOS-regression: Gluster Build System Smoke: Gluster Build System Reviewed-by: Jeff Darcy Reviewed-by: Shyamsundar Ranganathan --- libglusterfs/src/call-stub.c | 4 ++++ libglusterfs/src/common-utils.c | 2 ++ libglusterfs/src/gfdb/gfdb_sqlite3.c | 1 + 3 files changed, 7 insertions(+) (limited to 'libglusterfs') diff --git a/libglusterfs/src/call-stub.c b/libglusterfs/src/call-stub.c index c9c47b56c98..9aa67aab6c2 100644 --- a/libglusterfs/src/call-stub.c +++ b/libglusterfs/src/call-stub.c @@ -2218,11 +2218,13 @@ call_resume_wind (call_stub_t *stub) case GF_FOP_GETACTIVELK: stub->fn.getactivelk (stub->frame, stub->frame->this, &stub->args.loc, stub->args.xdata); + break; case GF_FOP_SETACTIVELK: stub->fn.setactivelk (stub->frame, stub->frame->this, &stub->args.loc, &stub->args.locklist, stub->args.xdata); + break; default: gf_msg_callingfn ("call-stub", GF_LOG_ERROR, EINVAL, @@ -2445,9 +2447,11 @@ call_resume_unwind (call_stub_t *stub) case GF_FOP_GETACTIVELK: STUB_UNWIND (stub, getactivelk, &stub->args_cbk.locklist, stub->args_cbk.xdata); + break; case GF_FOP_SETACTIVELK: STUB_UNWIND (stub, setactivelk, stub->args_cbk.xdata); + break; default: gf_msg_callingfn ("call-stub", GF_LOG_ERROR, EINVAL, diff --git a/libglusterfs/src/common-utils.c b/libglusterfs/src/common-utils.c index 1e77ebe6f29..51f97442fec 100644 --- a/libglusterfs/src/common-utils.c +++ b/libglusterfs/src/common-utils.c @@ -4517,6 +4517,8 @@ fop_enum_to_string (glusterfs_fop_t fop) "IPC", "SEEK", "COMPOUND", + "GETACTIVELK", + "SETACTIVELK", "MAXVALUE"}; if (fop <= GF_FOP_MAXVALUE) return str_map[fop]; diff --git a/libglusterfs/src/gfdb/gfdb_sqlite3.c b/libglusterfs/src/gfdb/gfdb_sqlite3.c index 70e38855fde..16930504742 100644 --- a/libglusterfs/src/gfdb/gfdb_sqlite3.c +++ b/libglusterfs/src/gfdb/gfdb_sqlite3.c @@ -1456,6 +1456,7 @@ gf_sqlite3_vacuum (void *db_conn, gf_boolean_t compact_active, break; case GF_SQL_COMPACT_MANUAL: changing_pragma = _gf_false; + break; default: ret = -1; gf_msg (GFDB_STR_SQLITE3, GF_LOG_ERROR, 0, -- cgit