From d724b4213902b694ec13a48bc4d55d538986787f Mon Sep 17 00:00:00 2001 From: Pranith Kumar K Date: Thu, 8 Dec 2016 14:53:04 +0530 Subject: cluster/ec: Fix lk-owner set race in ec_unlock Problem: Rename does two locks. There is a case where when it tries to unlock it sends xattrop of the directory with new version, callback of these two xattrops can be picked up by two separate epoll threads. Both of them will try to set the lk-owner for unlock in parallel on the same frame so one of these unlocks will fail because the lk-owner doesn't match. Fix: Specify the lk-owner which will be set on inodelk frame which will not be over written by any other thread/operation. >BUG: 1402710 >Change-Id: I666ffc931440dc5253d72df666efe0ef1d73f99a >Signed-off-by: Pranith Kumar K >Reviewed-on: http://review.gluster.org/16074 >Reviewed-by: Xavier Hernandez >Smoke: Gluster Build System >NetBSD-regression: NetBSD Build System >CentOS-regression: Gluster Build System BUG: 1412922 Change-Id: I18c553adaa0cbc8df55876accc1e1dcd4ee9c116 Signed-off-by: Pranith Kumar K Reviewed-on: http://review.gluster.org/16394 Smoke: Gluster Build System Reviewed-by: Xavier Hernandez CentOS-regression: Gluster Build System NetBSD-regression: NetBSD Build System --- libglusterfs/src/lkowner.h | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'libglusterfs') diff --git a/libglusterfs/src/lkowner.h b/libglusterfs/src/lkowner.h index b6a950f5e12..9712f176f30 100644 --- a/libglusterfs/src/lkowner.h +++ b/libglusterfs/src/lkowner.h @@ -84,4 +84,10 @@ out: return is_null; } +static inline void +lk_owner_copy (gf_lkowner_t *dst, gf_lkowner_t *src) +{ + dst->len = src->len; + memcpy(dst->data, src->data, src->len); +} #endif /* _LK_OWNER_H */ -- cgit