From f618c7e606caaf8371aea4a02b352c987b3b1a40 Mon Sep 17 00:00:00 2001
From: Niels de Vos <ndevos@redhat.com>
Date: Tue, 30 May 2017 13:10:50 +0530
Subject: scripts: prevent a script warning if rfc.sh does not find a backport

When running ./rfc.sh on a branch to post release notes (not a backport
from master), then the following script warning is displayed:

   ./rfc.sh: line 97: [: =: unary operator expected

In case the used variables are not set, they are not handled as empty
strings. Placing the variables inside "${qoutes}" prevents this warning.

BUG: 1428047
Change-Id: Ie171d6f66b47401d6ea4e78aa3ed2bd0c6fce9ce
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: https://review.gluster.org/17418
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
---
 rfc.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'rfc.sh')

diff --git a/rfc.sh b/rfc.sh
index 07d61ea95ae..0123a220776 100755
--- a/rfc.sh
+++ b/rfc.sh
@@ -94,7 +94,7 @@ check_backport()
         # NOTE: If master was not rebased, we will not find the Change-ID and
         # could hit a false positive case here (or if someone checks out some
         # other branch as master).
-        if [ $mchangeid = $changeid ]; then
+        if [ "${mchangeid}" = "${changeid}" ]; then
             moveon="Y"
         else
             backport_id_message;
-- 
cgit