From 4493bfd8421116b5f45638b2f839874921f73fb3 Mon Sep 17 00:00:00 2001 From: Avra Sengupta Date: Wed, 21 Jan 2015 08:25:23 +0000 Subject: glusterd/snapshot: Fail snap create even if one brick is down. In a n-way replication, where n>=3 fail snapshot, even if one brick is down. Also check for glusterd quorum, irrespective of the force option Modified testcase tests/bugs/snapshot/bug-1090042.t because it tested the successful creation of snapshot with force command. Change-Id: I72666f8f1484bd1766b9d6799c20766e4547f6c5 BUG: 1184344 Signed-off-by: Avra Sengupta Reviewed-on: http://review.gluster.org/9470 Reviewed-by: Rajesh Joseph Reviewed-by: Atin Mukherjee Tested-by: Gluster Build System Reviewed-by: Kaushal M --- tests/bugs/snapshot/bug-1090042.t | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) (limited to 'tests/bugs') diff --git a/tests/bugs/snapshot/bug-1090042.t b/tests/bugs/snapshot/bug-1090042.t index b4df8e6cebe..9eb3a9aecc4 100755 --- a/tests/bugs/snapshot/bug-1090042.t +++ b/tests/bugs/snapshot/bug-1090042.t @@ -19,12 +19,8 @@ TEST kill_brick $V0 $H0 $L1; TEST ! $CLI snapshot create ${V0}_snap1 $V0; TEST ! snapshot_exists 0 ${V0}_snap1; -#Force snap create should succeed -TEST $CLI snapshot create ${V0}_snap1 $V0 force; -TEST snapshot_exists 0 ${V0}_snap1; - -#Delete the created snap -TEST $CLI snapshot delete ${V0}_snap1; +#With changes introduced in BZ #1184344 force snap create should fail too +TEST ! $CLI snapshot create ${V0}_snap1 $V0 force; TEST ! snapshot_exists 0 ${V0}_snap1; cleanup; -- cgit