From 8202705f98d139ef7d691587b9f68cf1db2e397a Mon Sep 17 00:00:00 2001 From: Pranith Kumar K Date: Thu, 3 Jul 2014 06:50:56 +0530 Subject: features/gfid-access: Fix entry operations Problem: When more than one aux-mounts are performing rmdir .gfid//dir simultaneously, then sometimes a hang is observed. In gfid-access xlator When virtual parent/inode are replaced with real parent/inode in loc, virtual pargfid/gfid are not replaced with real pargfid/gfid respectively. Afr is using parent_loc->gfids to order the entry locks. But parent_loc->gfid contains random/virtual gfid generated by gfid-access xlator. Entrylk in client xlator is using loc->inod->gfid for sending entrylk which has 'real' gfid. Because the ordering is happening based on random gfids, One mount orders the locks as (L1, L2) where as the other orders them as (L2, L1) leading to a dead-lock thus a hang. Fix: Replace virtual pargfid/gfid with real pargfid/gfid when virtual-inodes are replaced with real-inodes in loc. BUG: 1114501 Change-Id: Ie94e816122ef9e7aad51605adbf49291de60827e Signed-off-by: Pranith Kumar K Reviewed-on: http://review.gluster.org/8204 Reviewed-by: Kotresh HR Reviewed-by: Vijay Bellur Tested-by: Vijay Bellur --- tests/basic/gfid-access.t | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) (limited to 'tests') diff --git a/tests/basic/gfid-access.t b/tests/basic/gfid-access.t index 24477acba5c..00e14235fee 100644 --- a/tests/basic/gfid-access.t +++ b/tests/basic/gfid-access.t @@ -36,6 +36,24 @@ TEST chmod 0777 $M0/.gfid/$a_gfid_str EXPECT "777" stat -c "%a" $M0/a EXPECT "777" stat -c "%a" $M0/.gfid/$a_gfid_str +#Entry operations on directory +#Test that virtual directories are not allowed to be deleted. +TEST ! mkdir $M0/.gfid +TEST ! rmdir $M0/.gfid +TEST ! touch $M0/.gfid +TEST ! rm -f $M0/.gfid +TEST ! mv $M0/.gfid $M0/dont-rename +TEST ! ln -s $M0/symlink $M0/.gfid +TEST ! ln $M0/.gfid $M0/hlink +TEST ! mknod $M0/.gfid b 0 0 + +#Test that first level directory/file creations inside .gfid are not allowed. +TEST ! mkdir $M0/.gfid/a +TEST ! touch $M0/.gfid/a +TEST ! mv /etc/passwd $M0/.gfid +TEST ! mv $M0/a $M0/.gfid +TEST ! mknod $M0/.gfid/b b 0 0 + #Operations on File TEST setfattr -n trusted.abc -v abc $M0/b EXPECT "abc" echo $(getfattr -n trusted.abc $M0/b) -- cgit