From 7cdcd9b022180ee279f6408f7daaa882a8266f3a Mon Sep 17 00:00:00 2001 From: "Kaleb S. KEITHLEY" Date: Wed, 30 May 2018 08:15:29 -0400 Subject: core/various: python3 compat, prepare for python2 -> python3 see https://review.gluster.org/#/c/19788/, https://review.gluster.org/#/c/19871/, and https://review.gluster.org/#/c/19952/ This patch adds version agnostic imports for urllib, cpickle, socketserver, _thread, queue, etc., suggested by Aravinda in https://review.gluster.org/#/c/19767/1 Note: Fedora packaging guidelines require explicit shebangs, so popular practices like #!/usr/bin/env python and #!/usr/bin/python are not allowed; they must be #!/usr/bin/python2 or #!/usr/bin/python3 Note: Selected small fixes from 2to3 utility. Specifically apply, basestring, funcattrs, idioms, numliterals, set_literal, types, urllib, and zip have already been applied. Note: these 2to3 fixes report no changes are necessary: exec, execfile, exitfunc, filter, getcwdu, intern, itertools, metaclass, methodattrs, ne, next, nonzero, operator, paren, raw_input, reduce, reload, renames, repr, standarderror, sys_exc, throw, tuple_params, xreadlines. Change-Id: I8d393064a1837874d8b4bc87c8ce05c679664642 updates: #411 Signed-off-by: Kaleb S. KEITHLEY --- tools/glusterfind/src/brickfind.py | 5 ++++- tools/glusterfind/src/changelog.py | 5 ++++- tools/glusterfind/src/conf.py | 5 ++++- tools/glusterfind/src/nodeagent.py | 5 ++++- 4 files changed, 16 insertions(+), 4 deletions(-) (limited to 'tools/glusterfind/src') diff --git a/tools/glusterfind/src/brickfind.py b/tools/glusterfind/src/brickfind.py index e24fb1f0bdf..6bfb997f5a0 100644 --- a/tools/glusterfind/src/brickfind.py +++ b/tools/glusterfind/src/brickfind.py @@ -13,7 +13,10 @@ import os import sys import logging from argparse import ArgumentParser, RawDescriptionHelpFormatter -import urllib.request, urllib.parse, urllib.error +try: + import urllib.parse as urllib +except ImportError: + import urllib import time from utils import mkdirp, setup_logger, create_file, output_write, find diff --git a/tools/glusterfind/src/changelog.py b/tools/glusterfind/src/changelog.py index 608b5c7c2de..5897f790d4b 100644 --- a/tools/glusterfind/src/changelog.py +++ b/tools/glusterfind/src/changelog.py @@ -16,7 +16,10 @@ import xattr import logging from argparse import ArgumentParser, RawDescriptionHelpFormatter import hashlib -import urllib.request, urllib.parse, urllib.error +try: + import urllib.parse as urllib +except ImportError: + import urllib import codecs import libgfchangelog diff --git a/tools/glusterfind/src/conf.py b/tools/glusterfind/src/conf.py index d91746bda13..fdab38badb1 100644 --- a/tools/glusterfind/src/conf.py +++ b/tools/glusterfind/src/conf.py @@ -9,7 +9,10 @@ # cases as published by the Free Software Foundation. import os -import ConfigParser +try: + import configparser +except ImportError: + import ConfigParser as configparser config = ConfigParser.ConfigParser() config.read(os.path.join(os.path.dirname(os.path.abspath(__file__)), diff --git a/tools/glusterfind/src/nodeagent.py b/tools/glusterfind/src/nodeagent.py index c337964c7db..4aed0e2ad96 100644 --- a/tools/glusterfind/src/nodeagent.py +++ b/tools/glusterfind/src/nodeagent.py @@ -14,7 +14,10 @@ import sys import os import logging from argparse import ArgumentParser, RawDescriptionHelpFormatter -import urllib.request, urllib.parse, urllib.error +try: + import urllib.parse as urllib +except ImportError: + import urllib from errno import ENOTEMPTY from utils import setup_logger, mkdirp, handle_rm_error -- cgit