From 8eaa3506ead4f11b81b146a9e56575c79f3aad7b Mon Sep 17 00:00:00 2001 From: Anuradha Talur Date: Tue, 23 Feb 2016 10:56:51 +0530 Subject: afr : Enable auto heal when replica count increases This patch is part two change to prevent data loss in a replicate volume on doing a add-brick operation. Problem: After doing add-brick, there is a chance that self heal might happen from the newly added brick rather than the source brick, leading to data loss. Solution: Mark pending changelogs on afr children for the new afr-child so that heal is performed in the correct direction. Change-Id: I11871e55eef3593aec874f92214a2d97da229b17 BUG: 1276203 Signed-off-by: Anuradha Talur Reviewed-on: http://review.gluster.org/12454 Smoke: Gluster Build System Reviewed-by: Pranith Kumar Karampuri Tested-by: Pranith Kumar Karampuri CentOS-regression: Gluster Build System NetBSD-regression: NetBSD Build System --- xlators/cluster/afr/src/afr-messages.h | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) (limited to 'xlators/cluster/afr/src/afr-messages.h') diff --git a/xlators/cluster/afr/src/afr-messages.h b/xlators/cluster/afr/src/afr-messages.h index fca94eeff6b..37736f5afa3 100644 --- a/xlators/cluster/afr/src/afr-messages.h +++ b/xlators/cluster/afr/src/afr-messages.h @@ -336,14 +336,16 @@ /*! * @messageid 108039 - * @diagnosis - * @recommendedaction + * @diagnosis Setting of pending xattrs succeeded/failed during add-brick + * operation. + * @recommendedaction In case of failure, error number in the log should give + * the reason why it failed. Also observe brick logs for more information. */ -#define AFR_MSG_REPLACE_BRICK_FAILED (GLFS_COMP_BASE_AFR + 39) +#define AFR_MSG_ADD_BRICK_STATUS (GLFS_COMP_BASE_AFR + 39) /*! - * @messageid 108039 + * @messageid 108040 * @diagnosis AFR was unable to be loaded because the pending-changelog xattrs * were not found in the volfile. * @recommendedaction Please ensure cluster op-version is atleast 30707 and the -- cgit