From 8a0f744c461166be483f28fe9da37732586585d8 Mon Sep 17 00:00:00 2001 From: Poornima Date: Tue, 3 Dec 2013 05:46:40 +0000 Subject: cluster/afr: handle NULL check before strlen/strcmp in fgetxattr xattr name can legally be NULL. Handle that case without crashing. Change-Id: Ie214cb05ccd52565dc247a9234ad83ae799d3866 BUG: 1036879 Signed-off-by: Poornima Reviewed-on: http://review.gluster.org/6412 Reviewed-by: Krishnan Parthasarathi Tested-by: Gluster Build System --- xlators/cluster/afr/src/afr-inode-read.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'xlators/cluster/afr/src') diff --git a/xlators/cluster/afr/src/afr-inode-read.c b/xlators/cluster/afr/src/afr-inode-read.c index ac64a763626..8a2853319c5 100644 --- a/xlators/cluster/afr/src/afr-inode-read.c +++ b/xlators/cluster/afr/src/afr-inode-read.c @@ -1405,7 +1405,7 @@ afr_is_special_xattr (const char *name, fop_getxattr_cbk_t *cbk, gf_boolean_t is_spl = _gf_true; GF_ASSERT (cbk); - if (!cbk) { + if (!cbk || !name) { is_spl = _gf_false; goto out; } -- cgit