From 430ad405294993ebb16387232281cc5a4f854c75 Mon Sep 17 00:00:00 2001 From: N Balachandran Date: Wed, 16 Dec 2015 21:09:22 +0530 Subject: cluster/dht : Ftruncate on migrating file fails with EINVAL What: If dht_open is called on a migrating file after the inode_ctx is set, subsequent FOPs on that fd do not open the fd on the dst subvol. This is seen when the open-ftruncate-close sequence is repeatedly called on a migrating file. A second call to the sequence described above causes dht_truncate_cbk to call dht_truncate2 as the dht_inode_ctx was already set by the first call. As dht_rebalance_in_progress_check is not called, the fd is not opened on the dst subvol. On a distributed-replicate volume, this causes AFR to open the fd using afr_fix_open, but with the wrong flags, causing posix_ftruncate to fail with EINVAL. The fix: We require fd specific information to make a decision while handling migrating files. Set the fd_ctx to indicate the fd has been opened on the dst subvol and check if it has been set while processing Phase1/Phase2 checks in the FOP callback functions. Change-Id: I43cdcd8017b4a11e18afdd210469de7cd9a5ef14 BUG: 1284823 Signed-off-by: N Balachandran Reviewed-on: http://review.gluster.org/12985 Reviewed-by: Raghavendra G Tested-by: Gluster Build System Reviewed-by: Dan Lambright Tested-by: Dan Lambright --- xlators/cluster/dht/src/dht.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'xlators/cluster/dht/src/dht.c') diff --git a/xlators/cluster/dht/src/dht.c b/xlators/cluster/dht/src/dht.c index 0e636e1ff3b..aa3080c420d 100644 --- a/xlators/cluster/dht/src/dht.c +++ b/xlators/cluster/dht/src/dht.c @@ -77,7 +77,7 @@ struct xlator_dumpops dumpops = { struct xlator_cbks cbks = { -// .release = dht_release, + .release = dht_release, // .releasedir = dht_releasedir, .forget = dht_forget }; -- cgit