From 17d719c9ba08ba6b6eb040723f78cfa45b0c2ae7 Mon Sep 17 00:00:00 2001 From: arao Date: Tue, 17 Feb 2015 14:54:45 +0530 Subject: features/snapview-server: Fixing explicit null dereferencing. CID: 1238184 The pointer was not checked for null before dereferencing in the 'out' label, which is resolved now. Change-Id: I8aa7520102b84f63727754b8ac9c1f87ef8a6671 BUG: 789278 Signed-off-by: arao Reviewed-on: http://review.gluster.org/9662 Tested-by: Gluster Build System Reviewed-by: Vijay Bellur --- xlators/features/snapview-server/src/snapview-server-mgmt.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) (limited to 'xlators/features/snapview-server') diff --git a/xlators/features/snapview-server/src/snapview-server-mgmt.c b/xlators/features/snapview-server/src/snapview-server-mgmt.c index f2a1e7b7893..a4ce89cd47c 100644 --- a/xlators/features/snapview-server/src/snapview-server-mgmt.c +++ b/xlators/features/snapview-server/src/snapview-server-mgmt.c @@ -111,11 +111,12 @@ svs_mgmt_init (xlator_t *this) gf_log (this->name, GF_LOG_DEBUG, "svs mgmt init successful"); out: - if (ret) { - rpc_clnt_connection_cleanup (&priv->rpc->conn); - rpc_clnt_unref (priv->rpc); - priv->rpc = NULL; - } + if (ret) + if (priv) { + rpc_clnt_connection_cleanup (&priv->rpc->conn); + rpc_clnt_unref (priv->rpc); + priv->rpc = NULL; + } return ret; } -- cgit